Skip to content

Conversation

@vrvencislavov
Copy link
Contributor

@vrvencislavov vrvencislavov self-assigned this Oct 3, 2025
@vrvencislavov vrvencislavov requested a review from dpaskov October 3, 2025 14:40
Copy link

@biyoyo biyoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

@GalinaDimitrova GalinaDimitrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@GalinaDimitrova GalinaDimitrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

super().__init__(max_runs=max_runs, needs_prev_result=needs_prev_result, name=name)
self._func = func
self._args = args or []
self._date_updated = None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self._date_updated = None
self._execution_end_time = None

Sounds more consistent to me 🤔

Copy link

@iliyandd iliyandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vrvencislavov vrvencislavov merged commit a665100 into master Oct 8, 2025
3 checks passed
@vrvencislavov vrvencislavov deleted the improvement/task-execution-start-time branch October 8, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants