♻️ Make DN404 zksync / abstract compatible #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
reviewed
Dec 29, 2024
Collaborator
cygaar
left a comment
cygaar
left a comment
There was a problem hiding this comment.
lgtm outside of the permit2 address
| /// @dev The ZKsync Permit2 deployment. | ||
| /// If deploying on ZKsync or Abstract, override `_isPermit2(address)` to check against this too. | ||
| /// [Etherscan](https://era.zksync.network/address/0x0000000000225e31D15943971F47aD3022F714Fa) | ||
| address internal constant _ZKSYNC_PERMIT_2 = 0x0000000000225e31D15943971F47aD3022F714Fa; |
Collaborator
There was a problem hiding this comment.
The abstract permit2 address is actually: 0x6b4420f66De496D18A6c36367cf7f1440fd9289f
Do you need it specifically at the address above?
Owner
Author
There was a problem hiding this comment.
Oh my. fragmentation. Best to get it at the same address!
Owner
Author
There was a problem hiding this comment.
It’s not yet up, https://explorer.testnet.abs.xyz/address/0x6b4420f66De496D18A6c36367cf7f1440fd9289f
so better fix now b4 mainnet.
Collaborator
There was a problem hiding this comment.
I'll try to get it deployed to the same address
| /// @dev The ZKsync Permit2 deployment. | ||
| /// If deploying on ZKsync or Abstract, override `_isPermit2(address)` to check against this too. | ||
| /// [Etherscan](https://era.zksync.network/address/0x0000000000225e31D15943971F47aD3022F714Fa) | ||
| address internal constant _ZKSYNC_PERMIT_2 = 0x0000000000225e31D15943971F47aD3022F714Fa; |
Owner
Author
|
Much thanks @cygaar @coffeexcoin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
♻️
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.