Duelist effect values calculation rework #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: unfortunately, Duelist effect looks like as little overengineered one. It's very difficult to balance it properly within the whole set of items with very different damages ranges and predict it real ingame values (especially, taking into account that it is added additively after parry modification effect which is added multiplicatively - looks as refactoring bug than as intended behavior). Moreover, the effect is comletely useless in early game when weapon damage is low despite providing like x2 parry force or even more parry for early game items it totally fine.
Proposed changes don't affect the main idea of Duelist effect - the effect is still providing block and parry force bonuses only when no off-hand is being used by the player and affects parry force less than block. Now it works additively with other source of block/parry force making calculations and understanding of the values much easy for the player.
Backward compatibility: doesn't affect default configurations much except making Duelist noticeable for early game items, requires FominArtmind:pr-split-parry-and-parry-force to be accepted first to avoid merge conflicts.