forked from RandyKnapp/ValheimMods
-
Notifications
You must be signed in to change notification settings - Fork 2
Implemented loot filter #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FominArtmind
wants to merge
18
commits into
Vapok:releases/EpicLoot/v0.9.37-vapok
Choose a base branch
from
FominArtmind:pr-loot-filter
base: releases/EpicLoot/v0.9.37-vapok
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implemented loot filter #16
FominArtmind
wants to merge
18
commits into
Vapok:releases/EpicLoot/v0.9.37-vapok
from
FominArtmind:pr-loot-filter
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that is, always increase chances for the highest rarity available)
…tting on item creation
…n, Elite) and the corresponding ValuesPerRarityExceptional, ValuesPerRarityElite config for magiceffects.json
…xceptional unique item if the related config doesn't possess the required quality effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: loot filters are important part of the games with reach loot system. For "the origin" Diablo 2 many third party software has been specifically implemented for the purpose, as for many more modern games, they have provided loot filter from a box. For Valheim (with item cluttering being one of the biggest not solved problem of the game design in it), the possibility to reduce potential cluttering is vital.
What has been implemented:
Blacklist filters can be configured to prevent specific items from dropping completely or to auto convert the matching items to materials. Whitelists prevent items from matching to any blacklist.
Each filter has the following configuration properties:
Not implemented but potentially usefull to implement is "Day" property which can control day of the world the filter starts to be applied from (to match CreatureLevelControl alternative world level setting).
Backward compatibility: similar to ItemName filter, requires FominArtmind:pr-item-name-in-magic-item, FominArtmind:pr-quality-of-items, FominArtmind:pr-loottables-distance-config, FominArtmind:pr-changed-item-gating-to-replacing-with-materials to be accepted first to avoid merge conflicts.