Modify attack speed effect recently introduced bug fix #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FominArtmind
changed the title
FominArtmind
pushed a commit
to FominArtmind/ValheimMods
that referenced
this pull request
Jan 26, 2025
…d 16 new magic effects with bug fixes, prep for version 0.10.4 (Vapok#10)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: looks like 18.09.2023 commit added bug making attack speed modifier to work in additive not multiplicative way. That results in modificator working illogical (the same value for knives and hammers work very differently) and also having choppy animation (changing real speed on the fly) even for particular weapon when it consists of several different length frames.
Backward compatibility: naturally affects every user but should not break anything