Skip to content

refactor: Rewrite optimization engine in Rust using samyama-optimizat…#3

Merged
vinod-dega merged 13 commits intomainfrom
feature/rust
Jan 22, 2026
Merged

refactor: Rewrite optimization engine in Rust using samyama-optimizat…#3
vinod-dega merged 13 commits intomainfrom
feature/rust

Conversation

@sandeepkunkunuru
Copy link
Member

…ion crate

Description 📝

Please provide a larger description of what did you do in this PR

GITHUB ISSUE 🎟️

Please provide the ticket related to this PR, using a link
https://github.com/VaidhyaMegha/issues/865

FYI 🙋

Please tag (@) people who need to be noticed about this changes

Screenshots 📸

Please add a screenshot or video if it's needed to show us the changes implemented (if needed)

Test ✍️

Please provide instructions to run test for this new code (if needed)

vinod-dega
vinod-dega previously approved these changes Jan 16, 2026
@sandeepkunkunuru sandeepkunkunuru dismissed stale reviews from vinod-dega and ghost via 36534ef January 16, 2026 16:48
- Reduced num_iterations to 50 and population_size to 20 across all tests
- Relaxed assertion thresholds for stochastic algorithms to prevent flaky failures with reduced compute
- Should resolve the hanging/slow GitHub Actions workflow
- Use py.allow_threads() around solver calls to release the GIL
- This prevents deadlocks when Rayon threads inside the solver try to acquire the GIL to call Python objective functions
- Added tests/test_config.py to centralize test parameters
- Increased default iterations to 200 and population to 50 (approx 24s total runtime)
- Fixed bugs in rao_algorithms/algorithms.py related to track_history return values
- Fixed assertions in test_convergence_history.py
This fixes the CI build error by ensuring the dependency can be cloned by GitHub Actions without private GitLab credentials.
This fixes ModuleNotFoundError in GitHub Actions by making 'tests' a proper Python package, allowing imports like 'from tests.test_config import ...' to work correctly.
Copy link
Contributor

@vinod-dega vinod-dega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinod-dega vinod-dega merged commit 4dde9ff into main Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants