Conversation
Collaborator
Author
|
Benchmarking the changes here is a bit disappointing: in the situation where this would be expected to make the biggest difference (lots of parallel searches with low number of threads), computing times for this PR are not significantly lower than with the previous hard-coded splitting logic. While the new code may look slightly simpler, I'll probably simply close this to avoid touching something that just works. |
Collaborator
Author
|
On second thoughts I'll probably merge this even with slight computing time improvements as the parallelization logic is now simpler and also consistent with #1292. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1305
Tasks
counting_semaphoreto limit concurrencyCHANGELOG.md