feat: add solvelimit to config.yaml, matching timeout value#105
Open
cstenico wants to merge 1 commit intoVROOM-Project:masterfrom
Open
feat: add solvelimit to config.yaml, matching timeout value#105cstenico wants to merge 1 commit intoVROOM-Project:masterfrom
cstenico wants to merge 1 commit intoVROOM-Project:masterfrom
Conversation
jcoupey
reviewed
Jul 30, 2024
Contributor
jcoupey
left a comment
jcoupey
left a comment
There was a problem hiding this comment.
Thanks for the PR, I can definitely see that this may be useful. Only concern here is that there is actually no default value for -l when using vroom on the command-line, so we'd go from no limit down to 300 seconds by default.
| planmode: false # run vroom in plan mode (-c) if set to true | ||
| threads: 4 # number of threads to use (-t) | ||
| explore: 5 # exploration level to use (0..5) (-x) | ||
| solvelimit: 300 # stop solving process after 'limit' seconds (-l) |
Contributor
There was a problem hiding this comment.
Will change behavior as the default for -l on the command-line is no limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to set the solvelimit parameter in config.yaml for VROOM-Express. The proposed value matches the default VROOM timeout, allowing the time limit to be configured globally instead of being specified in each request.
Changes:
Benefits: