Skip to content

Enabling Plan mode on pyvroom#129

Open
blegat wants to merge 24 commits intoVROOM-Project:mainfrom
blegat:bugfix/plan-mode
Open

Enabling Plan mode on pyvroom#129
blegat wants to merge 24 commits intoVROOM-Project:mainfrom
blegat:bugfix/plan-mode

Conversation

@blegat
Copy link
Contributor

@blegat blegat commented Feb 11, 2026

Rebased #84, fixed conflicts, added a tests and tried to fix Mac OS

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.6%. Comparing base (39d4e1f) to head (8e78878).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #129      +/-   ##
========================================
+ Coverage   40.3%   80.6%   +40.3%     
========================================
  Files         29      29              
  Lines       1630    1801     +171     
  Branches     147     140       -7     
========================================
+ Hits         657    1452     +795     
+ Misses       973     339     -634     
- Partials       0      10      +10     
Flag Coverage Δ
binding 73.0% <100.0%> (+73.0%) ⬆️
python 92.2% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

5 48 job 1102 3 1717
6 48 job 2204 2 1616
7 48 end 2204 2 <NA>
>>> groups = solution.routes[solution.routes.type == "job"].groupby("vehicle_id")["id"].apply(lambda x: set(x.dropna().astype(int)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two possible solutions:

  • Vehicle 47: jobs in order 1414, 1515 (was 1515, 1414), with arrivals 0, 2104, 4207 for the two jobs.
  • Vehicle 48: jobs in order 1616, 1717 (was 1717, 1616), with arrivals 0, 1102, 2204 for the two jobs.
    Cost stays 6411; the solver is just returning a different (equivalent) route order.

This makes the doctest fail on ci if I write one solution here and the solver returns another one.
The change here make it work in both cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants