Skip to content

Conversation

@inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Jan 30, 2026


  • [ ] Unit-тесты
  • [ ] e2e-тесты
  • [ ] Дизайн-ревью
  • [ ] Документация фичи
  • Release notes

Описание

  • Деструктурируем свойства hoverMode и acitveMode из пропов, чтобы учитывать пользовательские значения.
  • Дополнительно вынес activeEffectDelay в декструтуризацию пропсов и там задаю значение по умолчанию.

Release notes

Исправления

  • PanelHeaderButton: hoverMode={undeined} и/или activeMode={undeined} не перебивают значения по умолчанию

@inomdzhon inomdzhon requested a review from a team as a code owner January 30, 2026 09:08
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 30, 2026
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 411.27 KB (+0.01% 🔺)
JS (gzip) 126.18 KB (0%)
JS (brotli) 104.24 KB (-0.08% 🔽)
JS import Div (tree shaking) 811 B (0%)
CSS 373.51 KB (0%)
CSS (gzip) 46.28 KB (0%)
CSS (brotli) 36.57 KB (0%)

@github-actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit c9a1d2b

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9413/c9a1d2bf8023c1b28a1214431797783282d3807d/pkg/@vkontakte/vkui/_pkg.tgz

Commit c9a1d2b

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (aac3afc) to head (c9a1d2b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9413      +/-   ##
==========================================
+ Coverage   94.72%   94.78%   +0.06%     
==========================================
  Files         440      440              
  Lines       11897    11890       -7     
  Branches     4387     4387              
==========================================
+ Hits        11269    11270       +1     
+ Misses        628      620       -8     
Flag Coverage Δ
unittests 94.78% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча ci:cherry-pick:v7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][PanelHeaderButton]: hoverMode={undeined} / activeMode={undeined} перебивает базовое поведение

2 participants