Let correlation endpoint accept only one dataset#93
Draft
Let correlation endpoint accept only one dataset#93
Conversation
Member
Author
|
@bobular if possible i'd like to merge this quickly and come back to fix things in a new PR if possible. I'm trying to work on the frontend simultaneously but running the backend locally is slowing dev. |
Member
Author
|
Don't review! I've introduced a bug and i must squash it first. Can see that now mbio correlations don't work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #92
For wgcna, we'd like the user to run correlation on 1 (self-correlation) or 2 datasets. Currently we have a separate endpoint for self-correlation.
This PR does a few things:
hasSecondCollectiontohasTwoCollectionsIt's looking like the frontend will be sending in data2==data1. Still, both this avenue and data2=null work and seem like reasonable ways to use the endpoint, so i'm partial to keeping both options but could be persuaded otherwise!
To test, use eda-inc and here's an example request:
To test data1 == data2,