Skip to content

Ask scatterplot to return the record ids of each point#76

Merged
asizemore merged 3 commits intomasterfrom
scatter-return-pointIds
Feb 19, 2025
Merged

Ask scatterplot to return the record ids of each point#76
asizemore merged 3 commits intomasterfrom
scatter-return-pointIds

Conversation

@asizemore
Copy link
Member

@asizemore asizemore commented Feb 7, 2025

This feature will be useful for highlighting a specific point in a scatterplot. Relies on VEuPathDB/plot.data#264

Status:

  • successful response!
  • need to add api and ensure normal scatters are not getting the extra ids back.

Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft, but is the scatterplot endpoint always going to return point IDs?

Or will the endpoint receive a new config parameter?

@asizemore
Copy link
Member Author

The endpoint now has a new config parameter called returnPointIds. It defaults to FALSE because we don't want them for most scatterplots right now

@asizemore asizemore marked this pull request as ready for review February 13, 2025 13:23
@asizemore asizemore requested a review from bobular February 13, 2025 13:23
@asizemore asizemore merged commit 526fac4 into master Feb 19, 2025
@asizemore asizemore deleted the scatter-return-pointIds branch February 19, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants