Reworking of Paraview and TTK build: catalyst adaptor working in WFA #6
Conversation
CharlesGueunet
left a comment
CharlesGueunet
left a comment
There was a problem hiding this comment.
I do not understand where is built the TTK module now, is this PR dependant on #5 ?
| cmake_vars[PARAVIEW_BUILD_EDITION]=CATALYST_RENDERING | ||
| cmake_vars[paraview_SOURCE_SELECTION]=$version | ||
| cmake_vars[ENABLE_boost]=ON | ||
| cmake_vars[USE_SYSTEM_boost]=ON |
There was a problem hiding this comment.
why using the system boost ?
There was a problem hiding this comment.
I'd equally ask why not? Boost is available as a system module so means the install is a little faster and uses less disk
| # TTK needs a patched version of Paraview | ||
| pv_version=5.8.1 | ||
| pv_source_dir_name=ParaView-v$pv_version | ||
| pv_version=5.9.0 |
|
|
||
| visibility=public | ||
| name=paraview | ||
| version=5.9.0 |
There was a problem hiding this comment.
we should use 5.9.1, or even master / git
| cmake_vars[USE_SYSTEM_boost]=ON | ||
| cmake_vars[ENABLE_numpy]=ON | ||
| cmake_vars[USE_SYSTEM_numpy]=ON | ||
| cmake_vars[ENABLE_protobuf]=ON |
There was a problem hiding this comment.
Where is TTK now ? in #5 I update this part to use the one provided by the superbuild
|
TTK is built as a separate module, as before. Except now this module does not need to build its own, patched, version of ParaView |
|
I should add that this does not depend on #5, but this is now installed and working on Cirrus at least. |
This branch removes TTK's patch of paraview and just build that normally via super build. PV now includes GDAL and numpy. I've also updated the build of WFA to enable catalyst by default.