Release: 2.24.4 #181
Release: 2.24.4 #181
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
📝 WalkthroughWalkthroughBumps release from 2.24.3 to 2.24.4: updates Android build dependency versions and package metadata, adds a new CHANGELOG entry, adjusts test mock data, and modifies Kotlin test FakePromise reject method signatures to accept nullable codes and an added overload. Changes
Sequence Diagram(s)(Skipped) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Code Suggestions ✨No code suggestions found for the PR. |
codeant-ai
bot
added
the
size:S
|
PR Summary: Release 2.24.4: version bumps and changelog update documenting CTV and Legitimate Interest UI/behavior improvements; no runtime logic changes.
|
Nitpicks 🔍
|
|
CodeAnt AI finished reviewing your PR. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Line 6: In the CHANGELOG entry line that reads '* Updated logic to ensure
unsaved Legitimate Interest settings are correctly captured even after a user
clicks "Deny All.' add the missing closing quotation mark after Deny All so it
reads "Deny All", and verify punctuation/spacing remains correct (ensure the
sentence ends with a period outside the closing quote).
🧹 Nitpick comments (1)
CHANGELOG.md (1)
7-7: Inconsistent naming: "AppleTV" vs "Apple TV".The same line uses "Android TV" (two words) but "AppleTV" (one word). For consistency and to match Apple's official branding, consider using "Apple TV" (two words).
📝 Proposed fix
-* Added status text for Legitimate Interest (LI) toggles on Android TV and AppleTV to clearly show if they are enabled/disabled +* Added status text for Legitimate Interest (LI) toggles on Android TV and Apple TV to clearly show if they are enabled/disabled
| ## Improvement | ||
| * Added a new feature allowing admins to show or hide the "Manage Settings" button | ||
| * Added TCF Storage Disclosures and detailed storage information views for CTV. | ||
| * Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All. |
There was a problem hiding this comment.
Missing closing quotation mark.
The sentence has an unclosed quotation mark around "Deny All".
📝 Proposed fix
-* Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All.
+* Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All. | |
| * Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All." |
🤖 Prompt for AI Agents
In `@CHANGELOG.md` at line 6, In the CHANGELOG entry line that reads '* Updated
logic to ensure unsaved Legitimate Interest settings are correctly captured even
after a user clicks "Deny All.' add the missing closing quotation mark after
Deny All so it reads "Deny All", and verify punctuation/spacing remains correct
(ensure the sentence ends with a period outside the closing quote).
![pantoaibot[bot]](https://avatars.githubusercontent.com/in/934356?s=60&v=4){kind=small}
| ## Improvement | ||
| * Added a new feature allowing admins to show or hide the "Manage Settings" button | ||
| * Added TCF Storage Disclosures and detailed storage information views for CTV. | ||
| * Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All. |
There was a problem hiding this comment.
[NITPICK] Typo / punctuation: the line reads ...after a user clicks "Deny All. — the closing quotation mark is missing. Fix to: * Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All".
* Updated logic to ensure unsaved Legitimate Interest settings are correctly captured even after a user clicks "Deny All".
| @@ -1,4 +1,4 @@ | |||
| val usercentricsVersion = "2.24.3" | |||
| val usercentricsVersion = "2.24.4" | |||
There was a problem hiding this comment.
[VALIDATION] You updated usercentricsVersion to "2.24.4". Before publishing, validate that the native dependency com.usercentrics.sdk:usercentrics-ui:2.24.4 is available in your artifact repository (or that the intended publishing pipeline will publish it). Run a full Android CI build to verify dependency resolution and that both legacy and new gradle configs resolve the new version correctly.
|
Reviewed up to commit:58f5ca021a0f33334466fb84e5cbe8aaeada415e |
User description
User description
Release: 2.24.4
PR Type
Other
Description
Bumped version from 2.24.3 to 2.24.4
Updated Android build configuration with new version
Updated package.json version and iOS package version
Added comprehensive changelog entries for 2.24.4 release
Diagram Walkthrough
File Walkthrough
build.gradle.kts
Update Android Usercentrics versionandroid/build.gradle.kts
usercentricsVersionfrom 2.24.3 to 2.24.4package.json
Update package and iOS version numberspackage.json
versionfrom 2.24.3 to 2.24.4iosPackageVersionfrom 2.24.3 to 2.24.4CHANGELOG.md
Add 2.24.4 release notes and improvementsCHANGELOG.md
CodeAnt-AI Description
Release 2.24.4: Add CTV storage disclosures, admin control for Manage Settings, and clearer Legitimate Interest status on TV
What Changed
Impact
✅ Clearer Legitimate Interest status on TV✅ More transparent storage details on CTV✅ Admins control Manage Settings visibility💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
Chores
✏️ Tip: You can customize this high-level summary in your review settings.