added functionality for optional certificate file and domain names #1
Open
azet wants to merge 1 commit intoUnyonsys:masterfrom
azet:master
Open
added functionality for optional certificate file and domain names #1azet wants to merge 1 commit intoUnyonsys:masterfrom azet:master
azet wants to merge 1 commit intoUnyonsys:masterfrom
azet:master
Conversation
site.pp - e.g.:
class { 'sssd':
domains => ['example.com'],
use_ecryptfs => false,
tls_ca_file => "example_certificate.cert",
tls_domain => "sub.example.com",
}
Contributor
|
This is using dynamic lookup which is not working in Puppet3. I'll be happy to merge if you adress this. |
Author
|
Sorry, i'm pretty busy at the moment. Compability issues are not my main concern ATM. I don't have time to fix all of your code. |
Contributor
|
That's pretty rude answer when errors are in your own pull request... |
Author
|
I did not intend to sound rude at all, i apologize. Please correct me if i'm wrong, but your module uses dynamic lookup too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
site.pp - e.g.:
class { 'sssd':
domains => ['example.com'],
use_ecryptfs => false,
tls_ca_file => "example_certificate.cert",
tls_domain => "sub.example.com",
}