Fix showplan repairing #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems sensible! |
Member
Author
|
CI's happy now too! |
mstratford
approved these changes
Oct 4, 2025
Member
mstratford
left a comment
mstratford
left a comment
There was a problem hiding this comment.
Looks good! Yay for typing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How have we not noticed this since 2020...
We can't dispatch the repair ops locally yet, because we haven't even loaded the plan locally. This only worked because the
applyOpsreducer used to do nothing if there "was no plan loaded", except that that behaviour must have changed in an Immer update where the plan is no longer falsy. That needs more investigation, but for now this should work.