Skip to content

New config format#550

Open
Universal-Omega wants to merge 10 commits intomainfrom
configs
Open

New config format#550
Universal-Omega wants to merge 10 commits intomainfrom
configs

Conversation

@Universal-Omega
Copy link
Owner

@Universal-Omega Universal-Omega commented Feb 4, 2026

Summary by CodeRabbit

  • Chores
    • Standardized configuration setting naming convention. Legacy configuration format remains supported with deprecation notices.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch configs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@includes/Config.php`:
- Around line 20-83: buildConfigFromGlobalsAndLegacy currently writes legacy
values under the old legacy keys and lets legacy override new globals; change
the lookup order and the keys used: in the foreach over $map check
$globalConfig->has($newGlobalName) first and if present set
$settings[$newGlobalName] = $globalConfig->get($newGlobalName); otherwise if
isset($legacySettings[$key]) set $settings[$newGlobalName] =
$legacySettings[$key] and mark $usedLegacy = true. Update references to use the
$newGlobalName (ConfigNames::...) as the settings array key so
Config::get(ConfigNames::…) sees legacy fallbacks.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In `@includes/Parameters.php`:
- Around line 536-538: Reformat the multi-line ternary that assigns $max so the
'?' and ':' begin their own lines per MediaWiki style: locate the assignment
using $max and the ConfigNames::AllowUnlimitedResults /
ConfigNames::MaxResultCount calls and split the expression so the '?' is at the
start of the second line and the ':' at the start of the third line, preserving
the same logic and values (INF vs the MaxResultCount config).

In `@README.md`:
- Around line 49-53: In the README functional richness list, change the phrase
for $wgDPLFunctionalRichness = 2 from "adds performance equivalent features for
templates and pagelinks" to use a hyphenated adjective: "adds
performance-equivalent features for templates and pagelinks" so the compound
modifier is correct (locate the list item containing "$wgDPLFunctionalRichness =
2" and update the wording).
- Around line 25-39: The README config table wording is wordy; tighten
descriptions for clarity by shortening sentences and removing redundant phrases
for each setting (e.g., $wgDPLAllowedNamespaces, $wgDPLAllowUnlimitedCategories,
$wgDPLAllowUnlimitedResults, $wgDPLAlwaysCacheResults,
$wgDPLCategoryStyleListCutoff, $wgDPLFunctionalRichness, $wgDPLMaxCategoryCount,
$wgDPLMaxQueryTime, $wgDPLMaxResultCount, $wgDPLMinCategoryCount,
$wgDPLOverrideParameterDefaults, $wgDPLQueryCacheTime,
$wgDPLRecursivePreprocess, $wgDPLRecursiveTagParse,
$wgDPLRunFromProtectedPagesOnly) — keep parameter names and defaults unchanged
but replace long explanations with concise phrases (e.g., "Restrict DPL4 to
listed namespaces", "Allow unlimited categories (may impact performance)",
"Always enable parser cache", "Max items before a category list is cut off",
"Override default ParametersData values", "Suggested cache time: 30–600"), and
ensure warnings about performance or caching remain but shortened for
readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant