Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@includes/Config.php`:
- Around line 20-83: buildConfigFromGlobalsAndLegacy currently writes legacy
values under the old legacy keys and lets legacy override new globals; change
the lookup order and the keys used: in the foreach over $map check
$globalConfig->has($newGlobalName) first and if present set
$settings[$newGlobalName] = $globalConfig->get($newGlobalName); otherwise if
isset($legacySettings[$key]) set $settings[$newGlobalName] =
$legacySettings[$key] and mark $usedLegacy = true. Update references to use the
$newGlobalName (ConfigNames::...) as the settings array key so
Config::get(ConfigNames::…) sees legacy fallbacks.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@includes/Parameters.php`:
- Around line 536-538: Reformat the multi-line ternary that assigns $max so the
'?' and ':' begin their own lines per MediaWiki style: locate the assignment
using $max and the ConfigNames::AllowUnlimitedResults /
ConfigNames::MaxResultCount calls and split the expression so the '?' is at the
start of the second line and the ':' at the start of the third line, preserving
the same logic and values (INF vs the MaxResultCount config).
In `@README.md`:
- Around line 49-53: In the README functional richness list, change the phrase
for $wgDPLFunctionalRichness = 2 from "adds performance equivalent features for
templates and pagelinks" to use a hyphenated adjective: "adds
performance-equivalent features for templates and pagelinks" so the compound
modifier is correct (locate the list item containing "$wgDPLFunctionalRichness =
2" and update the wording).
- Around line 25-39: The README config table wording is wordy; tighten
descriptions for clarity by shortening sentences and removing redundant phrases
for each setting (e.g., $wgDPLAllowedNamespaces, $wgDPLAllowUnlimitedCategories,
$wgDPLAllowUnlimitedResults, $wgDPLAlwaysCacheResults,
$wgDPLCategoryStyleListCutoff, $wgDPLFunctionalRichness, $wgDPLMaxCategoryCount,
$wgDPLMaxQueryTime, $wgDPLMaxResultCount, $wgDPLMinCategoryCount,
$wgDPLOverrideParameterDefaults, $wgDPLQueryCacheTime,
$wgDPLRecursivePreprocess, $wgDPLRecursiveTagParse,
$wgDPLRunFromProtectedPagesOnly) — keep parameter names and defaults unchanged
but replace long explanations with concise phrases (e.g., "Restrict DPL4 to
listed namespaces", "Allow unlimited categories (may impact performance)",
"Always enable parser cache", "Max items before a category list is cut off",
"Override default ParametersData values", "Suggested cache time: 30–600"), and
ensure warnings about performance or caching remain but shortened for
readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit