-
Notifications
You must be signed in to change notification settings - Fork 2
227 groundwork links do not include base path on GitHub pages #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krowvin
wants to merge
27
commits into
main
Choose a base branch
from
227-groundwork-links-do-not-include-base-path-on-github-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
fbe5aaa
Correct existing base_url references from base to BASE_URL. Ensure we…
krowvin 8824057
Add BASE_URL to the lib Breadcrumbs/Header Image
krowvin 9d9cdc4
Add # to our base in the vite config for the Docs site and remove tra…
krowvin ccf501d
In the button show a base_url example and add a note about it
krowvin 8700c23
Can't have a hash in the base for vite!
krowvin 84ca7b0
Remove prepended slash, add missing BASE_URL
krowvin 413a17f
Add onclick catch to allow baseurl/# in the href paths
krowvin 3dc6bf1
Add missing baseurl to logout/login-button
krowvin df890c4
Add missing baseurl
krowvin 2b06d60
Remove unused comments
krowvin 633b21c
Fix popout menu header path, +base_url
krowvin 64f9d7e
Ensure baseurl with the hash if the hash is not present in the initia…
krowvin 6d8cf60
Passing in additional headless ui props and updated documentation (#232)
bmulcahy 34a842b
3.15.0
willbreitkreutz 6cded39
Modal update (#234)
bmulcahy 1868648
3.15.1
willbreitkreutz cce91a6
239 add issuefeature templates (#240)
krowvin 8cda638
235 home icon for breadcrumbs is always the root no base url (#236)
krowvin 4cd8213
3.15.2
willbreitkreutz 4c8cc5a
Keep text component, fix contrast (#252)
krowvin bf48750
3.15.3
willbreitkreutz 476c603
bump version of vite to satisfy npm audit (#226)
willbreitkreutz 2df8394
3.15.4
willbreitkreutz ac1e05e
Bump js-yaml from 4.1.0 to 4.1.1 (#250)
dependabot[bot] 1a1bb41
3.15.5
willbreitkreutz ff52bfa
Bump vite from 7.1.2 to 7.2.7 (#253)
dependabot[bot] 5afab4a
3.15.6
willbreitkreutz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: Groundwork Bug Report | ||
| description: File a bug report related to Groundwork | ||
| labels: ["bug"] | ||
| body: | ||
| # BUG REPORT FIELDS | ||
| - type: textarea | ||
| id: bug_description | ||
| attributes: | ||
| label: Describe the bug | ||
| description: What went wrong? | ||
| placeholder: | ||
| A clear and concise description of the bug... Include the version | ||
| of Groundwork if known. i.e. gw v0.0.1 (You can see this in your package.json file) | ||
| Provide any links to relevant code here. | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: logs | ||
| attributes: | ||
| label: REDACTED relevant log output | ||
| description: | ||
| Please copy and paste any relevant log output. Either runtime (dev console) or build logs. Removing sensitive | ||
| information. This will be automatically formatted into code, so no need for | ||
| backticks. | ||
| render: shell | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| id: repro_steps | ||
| attributes: | ||
| label: Steps to Reproduce | ||
| description: Provide steps to reproduce the issue. | ||
| placeholder: | | ||
| 1. npm install | ||
| 2. npm run dev | ||
| 3. Navigate to this page | ||
| 4. See error when clicking XYZ | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| blank_issues_enabled: true | ||
| contact_links: | ||
| - name: Groundwork Water | ||
| url: https://github.com/USACE-WaterManagement/groundwork-water/issues/new | ||
| about: Issues Related to Data/Hook Components or other water management data component problems. | ||
| - name: Groundwork Geo | ||
| url: https://github.com/USACE/groundwork-geo/issues/new | ||
| about: Map component issues that do NOT fetch data and otherwise have trouble with rendering or feature requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Groundwork Feature Request | ||
| description: Request a feature related to Groundwork | ||
| labels: ["enhancement"] | ||
| body: | ||
| # FEATURE REQUEST FIELDS | ||
| - type: textarea | ||
| id: feature_description | ||
| attributes: | ||
| label: Feature Proposal | ||
| description: What do you want to see added or changed? | ||
| placeholder: | | ||
| Describe the feature, its motivation, and usage examples. | ||
| You can include code or other examples in code blocks. | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: related_links | ||
| attributes: | ||
| label: Related Context or Links | ||
| description: Include any discussions, docs, or libraries relevant to the request. | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as on breadcrumbs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import.meta.env.BASE_URLwill reflect the env of the build-time, not consumer build time. I think we should expose a new prop on the breadcrumbs at the top level that allows you to pass in the base_url and default to "/".Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved with #235, will come back for the rest!