Event Manager, onScriptLoad, onStart, FindItemBySection #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Xoduz wants to merge 6 commits into develop from event_manager_system_20260207

Collaborator

Xoduz commented Feb 7, 2026

[ADD] Added new JS Event that runs once for all scripts after shard has fully started up:
- onScriptLoad()
[ADD] Added new JS Event that runs for all instances of scripts attached to objects after shard has fully started up:
- onStart( myObj ) // myObj can be a Character, Item or TownRegion
[ADD] Added new JS Function to find nearest item with a specific section ID at a given location:
- FindItemBySection( x, y, z, world, sectionId, [instanceId] )
[ADD] Added new Event Manager system that initializes on shard startup, which listens to event registrations from other scripts and schedules these events to be run once, a number of times with an interval, or recurring on specific day(s)/time of the week. See UOX3 documentation for full details. System can be enabled or disabled via a new setting in uox.ini:
- EVENTMANAGERSYSTEM=0/1 // Defaults to enabled
[ADD] Added a global JS constant to detect in scripts whether UOX3 runs in debug mode:
- UOX_DEBUG_MODE // Ex: if( UOX_DEBUG_MODE )
[FIX] Fixed an incorrectly named socket variable in js/item/potion.js


          Event Manager, onScriptLoad, onStart, FindItemBySection

2ae1b42

- [ADD] Added new JS Event that runs once for all scripts after shard has fully started up:
  - onScriptLoad()
- [ADD] Added new JS Event that runs for all instances of scripts attached to objects after shard has fully started up:
  - onStart( myObj ) // myObj can be a Character, Item or TownRegion
- [ADD] Added new JS Function to find nearest item with a specific section ID at a given location:
  - FindItemBySection( x, y, z, world, sectionId, [instanceId] )
- [ADD] Added new Event Manager system that initializes on shard startup, which listens to event registrations from other scripts and schedules these events to be run once, a number of times with an interval, or recurring on specific day(s)/time of the week. See UOX3 documentation for full details. System can be enabled or disabled via a new setting in uox.ini:
  - EVENTMANAGERSYSTEM=0/1 // Defaults to enabled
- [ADD] Added a global JS constant to detect in scripts whether UOX3 runs in debug mode:
  - UOX_DEBUG_MODE // Ex: if( UOX_DEBUG_MODE )
- [FIX] Fixed an incorrectly named socket variable in js/item/potion.js

Xoduz requested review from DragonSlayer62 and strattond

February 7, 2026 11:12

DragonSlayer62 approved these changes

View reviewed changes

strattond requested changes

View reviewed changes

Contributor

strattond left a comment

Mostly all good. Probably needs a sync up, one obvious bug (a function that doesn't exist). The rest is largely cosmetic stuff.

data/dictionaries/dictionary.CSY Show resolved Hide resolved

data/js/item/potion.js Show resolved Hide resolved

data/js/server/event_manager.js Show resolved Hide resolved

data/js/server/event_manager.js Show resolved Hide resolved

data/js/server/event_manager.js Show resolved Hide resolved

source/cScript.cpp Show resolved Hide resolved

source/cServerData.h Show resolved Hide resolved

source/findfuncs.cpp Outdated Show resolved Hide resolved

source/findfuncs.cpp Outdated Show resolved Hide resolved

source/findfuncs.cpp Outdated Show resolved Hide resolved

Xoduz added 2 commits

February 12, 2026 02:33


          PR iteration

771a568

- [UPD] Updated FindItem() and FindItemBySection() JS Functions to also find items that are within +/- 5 Z of target location; Z no longer acts as an absolute condition
Added back in the dictionary entries for Dawn's Music Box, which somehow got lost in the first submission
Moved several Event Manager object properties from script to DFN
Added in typedef comments for functions in event manager script
Added in missing code to properly trigger onScriptLoad after script reloads


          Merge branch 'develop' into event_manager_system_20260207

4f3ad3d

Xoduz requested a review from strattond

February 12, 2026 06:43

strattond added 3 commits

February 12, 2026 16:45


          Update decls

ceb96da


          Minor bug fixes. Add UOXCFile. Add script_id property

8d7e777


          Define UOX_DEBUG_MODE as a constant. Fix up script_id

dc6d610

strattond force-pushed the event_manager_system_20260207 branch from a0adda5 to dc6d610 Compare

February 12, 2026 06:46

strattond requested changes

View reviewed changes

data/js/server/event_manager.js

+              					curEvent.enabled = newState;
+              					// Reschedule event to next valid window if it missed previous cycle
+              					if( newState === true && event.nextRun < new Date().getTime() )

Contributor

strattond Feb 12, 2026

Do you mean curEvent here? event doesn't exist?

data/js/server/event_manager.js

+              						if( !curEvent.isRunning )
+              						{
+              							socket.SysMessage( GetDictionaryEntry( 6520, socket.language )); // Event reenabled and rescheduled for next valid activation window.
+              							CalculateNextRun( event );

Contributor

strattond Feb 12, 2026

Likewise here - event vs curEvent

data/js/server/event_manager.js

+              				if( index >= 0 && index < gEventList.length )
+              				{
+              					let curEvent = gEventList[index];
+              					if( event.isRunning )

Contributor

strattond Feb 12, 2026

And here - do you mean curEvent?

data/js/server/event_manager.js

+              {
+              	let mFile = new UOXCFile();
+              	if( mFile.Open( eventDataFile, "w", eventDataFolder ))

Contributor

strattond Feb 12, 2026

So, this isn't going to do what you want - have a look at CFile_Open in the C++ code.

It doesn't return a value at all, it's a void return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet