Doxygen corrections #605
Merged
Doxygen corrections #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get the swig-generated wrappers to compile, we use #ifdef SWIG' in some .h files to change some definitions. However, by using `add_definitions`, we set this preprocessor variable also for compiling the registries. This can fail if these rely on the normal STIR definitions. This changes to use `-DSWIG` only for the wrappers. Fixes UCL#604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604
Also fixes some doxygen in the files, which were generating errors when running doxygen or doxygin2swig (although
makedidn't complain).Also adds an unrelated test case that I made to help debug the compilation problem in #577