-
Notifications
You must be signed in to change notification settings - Fork 100
LOR randomization in SAFIR input file format #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOR randomization in SAFIR input file format #507
Conversation
|
Two builds are failing because I use C++11 functionality. What is the current policy on that? |
|
Our announced policy is that C++11 is for STIR 5.0. However, I think that'll come really quickly, so I'm happy to switch off those Travis jobs once 4.0.0 is out. |
|
@KrisThielemans OK, great. Let's do it as you said. |
|
@jafische could you merge |
|
@KrisThielemans: Done. Let's see, what Travis says. |
|
@KrisThielemans: The g++5 builds still fail. I suppose, they need compiler flags -std=c++11 |
|
@jafische could you update this PR again? should work now I hope. Does this interfere with #577 ? The problem with LOR randomisation is that it will break symmetries, so enlarge the projection matrix, in most cases to unmanagable dimensions, such that caching has to be switched off. This currently probably doesn't have a large impact on run-time, unless you start using more LORs. But of course, it could be an interesting option to add. It's going to be a bit harder than hoped, as there's currently no mechanism to find detector locations in |
|
@KrisThielemans, sorry for the delay, a lot on my plate recently. Anyhow, addressing your questions in the last comments:
|
|
@jafische sorry, forgot to ask if you could add 1 line in |
|
@KrisThielemans Done. |
|
great. ok to squash-merge? (this is problematic if you've used this branch somewhere else already) |
|
@KrisThielemans : Squash-merge is OK for me. |
Dear Kris, dear all,
I have add a little feature to the SAFIR listmode input with the virtual scanner. With the new feature, endpoints of the LORs can be randomized with a Gaussian random number. This makes the image quality much better and the class actually much more useful. A lot of geometric artifacts vanish if this randomization is employed. I think it would make a good addition to the class also in the official STIR repo.
Kind regards
Jannis