-
Notifications
You must be signed in to change notification settings - Fork 100
Added Siemens Quadra scanner in the scanner.cxx and .h #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
an extra ring between "Vision 600" scanners? Need to do something with virtual rings then. |
|
FYI, discussion for future work (not this PR!) in #1388 |
|
To get this across the line, we need to change the |
KrisThielemans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Quadra to
STIR/src/buildblock/Scanner.cxx
Lines 1609 to 1611 in ec3a567
| case E1080: | |
| case Siemens_mCT: | |
| return 1; |
|
Hello Kris, get_num_axial_blocks() * get_num_axial_crystals_per_block() == get_num_rings() + get_num_virtual_axial_crystals_per_block(). So that, if (num_rings + num_virtual) is divisible by num_axial_crystals_per_block then the warning will be disappeared. So rather than using 10*8 axial crytals per block, I used 10 * 8 + 1 like in mCT. And the test passed. Please let me know your thoughts. |
KrisThielemans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Makes sense. thanks for correcting me! :-)
|
Can you please tick the box "The content of this Pull Request (the Contribution) is intentionally submitted ...". This change is small enough not to require the letter (although we'll have to look at that). |
Sure, I have ticked. |
Changes in this pull request
Added Siemens Quadra scanner in scanner.cxx and .h.
Testing performed
Built on own machine and test create_projdata_template.
Related issues
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)Contribution Notes
Please tick the following: