Open
Conversation
Contributor
Author
|
Note that this pull request should be handled before #6, as the latter needs some rework after/when this one is merged. |
rotty
force-pushed
the
debian-tweaks
branch
4 times, most recently
from
18e9652 to
e197929
Compare
Adjust dependencies:
- Don't depend on coreutils, which is marked essential (see Debian
Policy 3.5, "Dependencies").
- Fixup dependency on iproute/iproute2 -- according to the iproute2
Debian changelog, iproute acquired tuntap support in version
20100519-1, and iproute2 had it from the start.
A iproute with "tuntap" support should be in Debian distributions since
at least wheezy. Since we can reasonably depend on that nowadays,
simplify the ifupdown support scripts to use "ip tuntap", instead of
conditionally using "openvpn --mktun" or "tunctl" from uml-utilities.
Adapt handling of the quicktun user (see
<https://wiki.debian.org/AccountHandlingInMaintainerScripts> for the
guidelines followed):
- Make use of adduser instead of useradd, which allows to drop the
conditional, and will respect sysadmin settings in
/etc/adduser.conf.
- Create a system group as well. This allows for the private key file
to be owned by "root:quicktun", and have "-rw-r-----" as
permissions, allowing read-only access to the quicktun daemon, and
no-one else. Users of existing packages will have that group created
and the "quicktun" user's GID changed to it.
- Remove quicktun user and group on purge instead of on remove, and in
postrm instead of prerm. The removal will only happen if the "deluser"
command is present. The removal on purge should unproblematic, as
quicktun itself does not create any files (which then would be owned
by that user).
Contributor
Author
|
I've updated this PR to only include the packaging improvements, i.e., removed the "Handle ifupdown support in script" commit. I'd still like to follow up on the latter in a separate PR, but without duplicating the list of setting names into the ifupdown script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a dependency issue regarding iproute, and brings the user creation and removal more in line with Debian best practices. A quicktun system group is now available for use with private key files.