Open
Conversation
Extract the interface of common.c into a dedicated header, common.h, and use that instead of including the C file.
Remove the distinction between "combined binary" and per-protocol binary; only a the "combined" variant is built. For backward compatibility, the quicktun binary dispatches on argv[0], and uses the part after the last dot, if present, as a protocol name. If both are present, the protocol derived from the path takes precedence over the PROTOCOL setting, and a warning is printed to stderr. The build scripts now just creates compatibility symlinks instead of actually compiling code for each protocol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit series should be a reasonably self-contained attempt to eliminate the need for -DCOMBINED_BINARY.