Open
Conversation
TypeRegistry ------------- As part of adding new types, the TypeRegistry is now a class rather than a static object. This shows up in the Database class as db.types. A generic instance DefaultTypeRegistry uses hardcoded settings. Eventually, we'll be able to have a type registry that talks to the metadata repo. Type -> TUser + BaseType ------------------------- The majority of the code in this codebase is not aware of / set up to work with Mimir's user-defined types (TUser). That's something that's going to need to change over time, but due to the above fix, it's clear that we need to make the distinction more crisp. Now, there's a new (sealed abstract) subclass of Type called BaseType that is now the parent of all types except TUser. - The Type object is now the BaseType object and has nothing to do with TUser - TypeRegistry has been moved (see above) - Code without access to an instance of Database has been rewritten to use BaseType - Code with access to an instance of Database is uses the new TypeRegistry - To get the BaseType of a Type, use db.types.rootType OperatorTransforms -> Class ---------------------------- OperatorTransforms (both GProM and Spark) used a global Database instance. Database is enough of a hack... These have been rewritten to be classes with canonical instances accessible as db.gpromTranslator / db.sparkTranslator. Spark's OperatorTransforms retains several general methods in the global object.
…idators Mostly conflicts caused by the Type/BaseType change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small edits with far-reaching effects.
The big edits are:
Also cut out the OperatorTransform global database instance hack.