Adding user defined limiter fix, MF boundary and profiling improvements#538
Merged
klbudzin merged 9 commits intoUBCHREST:mainfrom May 7, 2025
Merged
Adding user defined limiter fix, MF boundary and profiling improvements#538klbudzin merged 9 commits intoUBCHREST:mainfrom
klbudzin merged 9 commits intoUBCHREST:mainfrom
Conversation
…e compressible flow solver register.
klbudzin
requested changes
May 1, 2025
… the absolute value of the gradient... Setting maxgradient to ablate::utilities::constants::large in finitevolume solver
klbudzin
approved these changes
May 7, 2025
| OPT(ablate::eos::transport::TransportModel, "evTransport", "when provided, this model will be used for ev transport instead of default"), | ||
| OPT(int, "compact", "Integer value describing whether to treat all the transport seperately, partially combined, or fully combined (see commented code above constructor for values)")); No newline at end of file | ||
| OPT(int, "compact", "Integer value describing whether to treat all the transport seperately, partially combined, or fully combined (see commented code above constructor for values)"), | ||
| OPT(int, "maxLimGrad", "Maximum gradient in any direction. If Cellinterpolant sees larger gradient, the limiter is set to 0.")); No newline at end of file |
kolosret
added a commit
to kolosret/ablate
that referenced
this pull request
Aug 5, 2025
…ts (UBCHREST#538) * Updated timestepper for accurate profiling results. * Patch from Kenny containing the massflux boundary condition. * Version bump * Correct formatting * removing extra variable.. * Bugfix: serializer returns 0 by default for optional arguments. Using the absolute value of the gradient... Setting maxgradient to ablate::utilities::constants::large in finitevolume solver * Final formatting, changing input type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1, Added maximum gradient option in cellinterpolant, over which we don't project the state to the face, we use cell-centered values. Recommended value is around 10000 for user.
2. Added mass flux boundary condition form Kenny's branch.
3. Added barrier in the timestepper between pre and evaluate step. This is to stop radiation gain load imbalance influencing flow data.