Adding ability to update multiple Fields at once with cell interpolants and face interpolants, #536
Merged
dsalac merged 19 commits intoUBCHREST:mainfrom Mar 30, 2025
Merged
Conversation
…up with mixed cells as well that I have to wait to be adressed
…ust commit the timers for now
… doesn't like to convert the shared pointer for a long int
… messed up with mixed cells as well that I have to wait to be adressed" This reverts commit 43fc1c0.
Contributor
|
Did we try to profile it with valgrind to make sure the memory leak isnt coming from here? |
Contributor
Author
|
The memory leak is the same one it has been with the hdf5 file saves |
kolosret
approved these changes
Mar 24, 2025
Contributor
Author
|
@dsalac Hey Dave! This is the multiple field input for face/cell interpolant calls we talked about quite a few months back. I finally had time to form the PR and wanted to know if this looks good to you or whether you'd like to do whatever you guys ended up doing for it. |
Contributor
|
Sounds good... |
Contributor
|
I'll take a look @klbudzin. |
Contributor
|
Looks good. I'll merge it. |
kolosret
pushed a commit
to kolosret/ablate
that referenced
this pull request
Aug 5, 2025
…ts and face interpolants, (UBCHREST#536) * Change to vector output for solution/aux field. Something got messed up with mixed cells as well that I have to wait to be adressed * Allow for multiple Fields to be updated in a flux/rhs calculation. * NavierStokes Interpolate advection Temperature * Test fix wasn't included * Add species and EV Guess temperatures * Add the compact transport solver, that still needs tests as well as just commit the timers for now * Few debug fixes * More debugging * More debugging, This one works fine * Rename in preperation for the one including the EV transport * change PetscInt to int because for some reason on lassen the compiler doesn't like to convert the shared pointer for a long int * Finished the compacting of the Compressible flow fields transport * Forgot to remove the timers I added. * Formatting * Missed a aux field input * My local presets snuck in to my last PR and were never caught. * Test additions and formatting issues * Revert "Change to vector output for solution/aux field. Something got messed up with mixed cells as well that I have to wait to be adressed" This reverts commit 43fc1c0. * Version Bump, will also want to figure out the .dev deploy before pushing to main --------- Co-authored-by: Kenneth Lawrence Budzinski <budzinsk@dane6.llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added temperature guessing during the Ausm flux calculations using old data.