Merged
Conversation
… changed with the method so will probably fail
…te fields in dmswarm(I believe) this is the first attempt at switching over what we are doing based on the changes to the petsc examples
…rticle solver unless petsc hates us.
…ly causing slightly different calculations for this test which is now fixed. Also included is the version bump, I figured we should finally jump to 13.0 since this is where ablate is now up to date with the latest PetsC.
kolosret
approved these changes
Feb 18, 2025
Contributor
kolosret
left a comment
kolosret
left a comment
There was a problem hiding this comment.
Looks good, thank you for fixing the tests and updating the petsc calls!
…it hangs with clang builds with 64 bit indices
kolosret
pushed a commit
to kolosret/ablate
that referenced
this pull request
Aug 5, 2025
* DMGetLocalSection API Change * Change to DMPlexInflate to have a toggle, unsure if other things have changed with the method so will probably fail * Matt Knepley changed how to grab the cell id and coordinates/coordinate fields in dmswarm(I believe) this switches over to that format * Have to switch the Set cell DM before finalizing the fields in the particle solver unless petsc hates us. * The way DMPLex generates a mesh from cad/stp files was changed slightly causing slightly different calculations for this test which is now fixed. Also included is the version bump, I figured we should finally jump to 13.0 since this is where ablate is now up to date with the latest PetsC. * Formatting * Removing compressibleFlowCadExample test until we can figure out why it hangs with clang builds with 64 bit indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been awhile since we have made sure the latest Petsc was compatable with Ablate. This PR fixes all the incompatabilities due to API changes/ Cad mesh generation/ DM Swarm changes.