Open
Conversation
models/solenoids/em-force-model.py
Outdated
|
|
||
| #outputs | ||
|
|
||
| Bs = ((mu*N*i)*(L+2*zp)*math.log((D+math.sqrt(pow(D, 2)+pow(L+2*zp, 2)))/(d+math.sqrt(pow(d, 2)+pow(L+2*zp, 2)))))/(2*L*(D-d)) + ((mu*N*i)*(L-2*zp)*math.log((D+math.sqrt(pow(D, 2)+pow(L-2*zp, 2)))/(d+math.sqrt(pow(d, 2)+pow(L-2*zp, 2)))))/(2*L*(D-d)) |
Collaborator
There was a problem hiding this comment.
Break down equation into parts
models/solenoids/em-force-model.py
Outdated
|
|
||
| Bs = ((mu*N*i)*(L+2*zp)*math.log((D+math.sqrt(pow(D, 2)+pow(L+2*zp, 2)))/(d+math.sqrt(pow(d, 2)+pow(L+2*zp, 2)))))/(2*L*(D-d)) + ((mu*N*i)*(L-2*zp)*math.log((D+math.sqrt(pow(D, 2)+pow(L-2*zp, 2)))/(d+math.sqrt(pow(d, 2)+pow(L-2*zp, 2)))))/(2*L*(D-d)) | ||
|
|
||
| a = (mu*N*i)*(L+2*zp)*math.log((D+math.sqrt(pow(D, 2)+pow(L+2*zp, 2)))/(d+math.sqrt(pow(d, 2)+pow(L+2*zp, 2)))) |
Collaborator
There was a problem hiding this comment.
more descriptive naming
hannahvsawiuk
requested changes
Oct 24, 2019
Collaborator
hannahvsawiuk
left a comment
hannahvsawiuk
left a comment
There was a problem hiding this comment.
Fix naming to be more descriptive, more comments, and add in a test file
Collaborator
hannahvsawiuk
left a comment
hannahvsawiuk
left a comment
There was a problem hiding this comment.
Looking really good! We will move this to software soon :)
Added docstrings to all methods/functions
…derbots/Electrical into feature/solenoid-models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.