-
Notifications
You must be signed in to change notification settings - Fork 21
New Starter Config Tutorial for Drupal 11 #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Added commit to address #406 |
q0rban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
| ]; | ||
|
|
||
| /** | ||
| * Set the memory limit for the CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Set the memory limit for the CLI. | |
| * Set the memory limit for the CLI (drush). |
| database: | ||
| # Drupal 11 requires MariaDB 10.6+ or MySQL 8.0+ | ||
| # Use MariaDB 10.11 for best compatibility | ||
| image: tugboatqa/mariadb:10.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you encounter the following issue using this version of MariaDB? https://docs.tugboatqa.com/troubleshooting/mysql-ssl-disabled/index.html
| # Run any commands needed to prepare the site. This is generally not needed | ||
| # for database services. | ||
| build: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this isn't needed, perhaps we remove it?
|
|
||
| # Increase PHP memory limit to 512MB for Drupal operations. | ||
| # Drupal 11 installation and updates can be memory-intensive. | ||
| - echo "memory_limit = 512M" >> /usr/local/etc/php/conf.d/tugboat.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is this necessary, or a holdover from a previous version? 512M seems high and can create issues with apache using a lot of memory for each thread.
|
|
||
| # Create any required directories that don't exist. | ||
| # Uncomment if using private files outside the webroot: | ||
| # - mkdir -p "${TUGBOAT_ROOT}/files-private" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this directory is created here, it will also need file permissions set properly. See the update phase for chmod-ing sites/default/files. In fact, we should probably move this step to update alongside the other files commands.
| # Uncomment and adapt these if your repository has custom code outside | ||
| # the standard Drupal directory structure: | ||
| # - ln -snf "${TUGBOAT_ROOT}/custom/themes" "${DOCROOT}/themes/custom" | ||
| # - ln -snf "${TUGBOAT_ROOT}/custom/modules" "${DOCROOT}/modules/custom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this common? If not, let's remove it.
| # copied to the external server in order to use rsync over SSH. More commonly | ||
| # we use Stage File Proxy, which we enable in the `build` step below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # copied to the external server in order to use rsync over SSH. More commonly | |
| # we use Stage File Proxy, which we enable in the `build` step below. | |
| # copied to the external server in order to use rsync over SSH. More common | |
| # is to use Stage File Proxy, which you can enable in the `build` steps below. |
| - vendor/bin/drush cache:rebuild | ||
| - vendor/bin/drush config:import --yes | ||
| - vendor/bin/drush updatedb --yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if nowadays drush deploy is the recommended step here? I recall there being some issues with it years ago, but I'd hope that those were resolved now.
|
|
||
| services: | ||
| # Define the database service. | ||
| database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about the order of the services in here (database first, then webserver)? For some reason I personally like webserver first, but when these got rewritten a few years back, they were switched around. Up to you, but just mentioning it in case you feel the same.
Adds a new starter config tutorial for Drupal 11 to Tugboat's documentation.
Resolves #440
And takes into account #406