🐛 Fixed 404s when using a proxy setup #11269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
force-pushed
the
fix-admin-access-with-reverse-proxies
branch
4 times, most recently
from
697c9dc to
dcd38ed
Compare
no issue When using certain proxy setups that result in `host` and `x-forwarded-host` being different, it became impossible to access Ghost because all routes showed generic 404 pages. - `vhost` module that we are using to separate front-end and admin urls does not use express' `req.hostname` so it does not pick up the `x-forwarded-host` url that express' `'trust proxy'` config gives us - switched to the forked `@tryghost/vhost-middleware` package which has a one-line change to use `req.hostname || req.host` - added `'trust proxy'` config to the admin express app and switched to using `req.hostname` in our redirect code to avoid infinite redirect loops
kevinansfield
force-pushed
the
fix-admin-access-with-reverse-proxies
branch
from
dcd38ed to
b4f7094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
When using certain proxy setups that result in
hostandx-forwarded-hostbeing different, it became impossible to access Ghost because all routes showed generic 404 pages.vhostmodule that we are using to separate front-end and admin urls does not use express'req.hostnameso it does not pick up thex-forwarded-hosturl that express''trust proxy'config gives us@tryghost/vhost-middlewarepackage which has a one-line change to usereq.hostname || req.host'trust proxy'config to the admin express app and switched to usingreq.hostnamein our redirect code to avoid infinite redirect loops