Skip to content

Conversation

@nicastel
Copy link
Contributor

This is a big one Nicola! Take your time for the review.

This pull request :

  • Add DDS with ETC1 support inside the WMS client (example included, needs to have dds with ETC1 support server side)
  • Add the capability to compress to DDS with ETC1 using the RenderscriptCompressor lib : Functionnality activated on BMNG and Landsat layer, to activate it in the xml : image/jpeg .dds png is not yet supported
  • By default JPEG are now decoded to RGB565 bitmap/texture instead of RGBA8888
  • Include some code to check if ETCx/DXTx are available at startup (but not yet used)

I have also made this changes :

  • hide the status bar
  • Full screen mode without navigation bar
    If you do not like it I will understand, Just do not implements those changes (inside WorldWindowActivity.java)

@ndorigatti
Copy link
Collaborator

Yes, it's a very big one!
I'll be out of office for the whole week and hence have no time to check/merge.
Status bar hiding is something we wanted to be but was in low priority.
Thank you very much, i'll review it as soon as possible.
I think now we need to fix elevation and after that the sdk can be considered quite good!

@nicastel
Copy link
Contributor Author

I have found some texture corruption problem when using the client side renderscript compressor. They are mostly visible when you tilt the view (wuth a very strange effect) wich means this is mot likely due to some problems during mipmap compression. For the time being it is better to deactivate client side texture compression by putting :
.jpg in BMNGWMSLayer.xml and EarthElevationModelAsBil16.xml

There is no such problem with server side on the fly compression with Geoserver (based on my JavaETC1) and Mapserver (based on gdal/crunch)

@ndorigatti
Copy link
Collaborator

I cant understand what you mean for, can you attach a screenshot?

Sent from my Nexus 4
Il 23/mag/2014 00:44 "nicastel" notifications@github.com ha scritto:

I have found some texture corruption problem when using the client side
renderscript compressor. They are mostly visible when you tilt the view
(wuth a very strange effect) wich means this is mot likely due to some
problems during mipmap compression. For the time being it is better to
deactivate client side texture compression by putting :
.jpg in BMNGWMSLayer.xml and EarthElevationModelAsBil16.xml

There is no such problem with server side on the fly compression with
Geoserver (based on my JavaETC1) and Mapserver (based on gdal/crunch)


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-43947995
.

Renderscript Compressor : Update to last version of Renderscript
Compressor
Renderscript Compressor : Handling of RGBA 8888 Images (still ignoring
alpha)
Renderscript Compressor : Improve performance of DDS/ETC1 with mipmap
compression 
Add of an example layer from my EC2 Mapserver with DDS/ETC1 plugin
Switch to an external datastore
@ndorigatti
Copy link
Collaborator

Hi @nicastel , i'm trying to merge the commits but i have problems with RS classes.
Eclipse blames about supportv8 package,
i dont know if committing RS part since you told creates artifact...

ndorigatti added a commit that referenced this pull request May 24, 2014
Merging changes to a new branch since RenderScript could cause some
issue,
and DDS part is not completely Flexible, but does ovverrides the actual
DDS handling  (DXT1)
@ndorigatti
Copy link
Collaborator

For now the merge has been done to a new branch, we need some testing and checking on DDS conversion (seems to be not completely flexible).
Thank you for the PR!

@nicastel
Copy link
Contributor Author

To be able to build Renderscript you need to install with the SDK Manager the Android SDK Build Tool 19.0.3

@ndorigatti
Copy link
Collaborator

Yes, i then manage it later, I did not merged the project.properties file.
Up to now, there is a branch dedicated to the merged @nicastel branch.
I'm going to do the same with @keidze branch and then look after to merge
the whole (I'm sorry but some things will be not merged due to both us
three worked on common things).

2014-05-24 13:35 GMT+02:00 nicastel notifications@github.com:

To be able to build Renderscript you need to install with the SDK Manager
the Android SDK Build Tool 19.0.3


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-44084704
.

Semaphore synchronisation to avoid paralell execution of renderscript
(already parallelized)
@nicastel
Copy link
Contributor Author

Hello, I fixed the image corruption problem by deactivating MipMap generation in the Renderscript ETC1 compressor (see my last commit).

About mipmap I am not so sure that they are useful in worldwind since they increase file size and compression time by ~40% and since WorldWind already have a pyramidal tiling system. I suppose that they can avoid some drop of performance during fast unzoom. Anyway the JPEG/PNG textures do not contains them so it will not create a regression of performance.

I will be happy to review keidze stuff also but as you noticed there is some build problems for now.

@ndorigatti
Copy link
Collaborator

Hello, glad to read the fixing of image corruption.
About mipmap, i dont know too, my colleague told me that there is no gain with mipmap but probably some loss (no technical values, just impressions).

I managed to make the library to compile from keidze pullrequest, the client is not updated i suppose, so we'd need to create a new one that uses his changes.
My colleague is working on keidze transparency and elevation commits, we have a code freeze before friday, so it's kinda a rush. After that we will dig better on the code and try to make a full merge of all the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants