-
Notifications
You must be signed in to change notification settings - Fork 10
Improve ETC1 support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Compatibility whith OPENGL ES 3.0 when available
Experimental real time texture compression using Renderscript (generated cache are OK but stability is affected)
by default => still experimental, generated cache are ok but cause crash Add of a WMS ETC1 example layer
|
Yes, it's a very big one! |
|
I have found some texture corruption problem when using the client side renderscript compressor. They are mostly visible when you tilt the view (wuth a very strange effect) wich means this is mot likely due to some problems during mipmap compression. For the time being it is better to deactivate client side texture compression by putting : There is no such problem with server side on the fly compression with Geoserver (based on my JavaETC1) and Mapserver (based on gdal/crunch) |
plugin for example)
|
I cant understand what you mean for, can you attach a screenshot? Sent from my Nexus 4
|
Renderscript Compressor : Update to last version of Renderscript Compressor Renderscript Compressor : Handling of RGBA 8888 Images (still ignoring alpha) Renderscript Compressor : Improve performance of DDS/ETC1 with mipmap compression Add of an example layer from my EC2 Mapserver with DDS/ETC1 plugin Switch to an external datastore
|
Hi @nicastel , i'm trying to merge the commits but i have problems with RS classes. |
Merging changes to a new branch since RenderScript could cause some issue, and DDS part is not completely Flexible, but does ovverrides the actual DDS handling (DXT1)
|
For now the merge has been done to a new branch, we need some testing and checking on DDS conversion (seems to be not completely flexible). |
|
To be able to build Renderscript you need to install with the SDK Manager the Android SDK Build Tool 19.0.3 |
|
Yes, i then manage it later, I did not merged the project.properties file. 2014-05-24 13:35 GMT+02:00 nicastel notifications@github.com:
|
Semaphore synchronisation to avoid paralell execution of renderscript (already parallelized)
|
Hello, I fixed the image corruption problem by deactivating MipMap generation in the Renderscript ETC1 compressor (see my last commit). About mipmap I am not so sure that they are useful in worldwind since they increase file size and compression time by ~40% and since WorldWind already have a pyramidal tiling system. I suppose that they can avoid some drop of performance during fast unzoom. Anyway the JPEG/PNG textures do not contains them so it will not create a regression of performance. I will be happy to review keidze stuff also but as you noticed there is some build problems for now. |
|
Hello, glad to read the fixing of image corruption. I managed to make the library to compile from keidze pullrequest, the client is not updated i suppose, so we'd need to create a new one that uses his changes. |
This is a big one Nicola! Take your time for the review.
This pull request :
I have also made this changes :
If you do not like it I will understand, Just do not implements those changes (inside WorldWindowActivity.java)