Anddev 8995/add new di #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkergoksu
requested review from
MertNYuksel,
bilgehankalkan and
celikrecep
MertNYuksel
previously approved these changes
Sep 9, 2025
bilgehankalkan
previously approved these changes
Sep 9, 2025
celikrecep
previously approved these changes
Sep 9, 2025
turkergoksu
dismissed stale reviews from celikrecep, bilgehankalkan, and MertNYuksel
via
94a69d5
bilgehankalkan
previously approved these changes
Sep 10, 2025
bilgehankalkan
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented koin library for the following modules:
analytics-logger
debug-menu
deeplink-launcher
environment-manager
sharedpref-manager
We decided to proceed with embedded koin in order to not interfere with the global koin instance. So for each module we created a koin instance inside the object class.
For sharedpref-manager we decided to define an activity scope. If we use the
singlefunction it keeps opening the first SharedPreferences instance it created.