Skip to content

Conversation

@MertNYuksel
Copy link
Member

No description provided.

@MertNYuksel MertNYuksel requested a review from Copilot August 27, 2025 04:21
@MertNYuksel MertNYuksel self-assigned this Aug 27, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for encrypted SharedPreferences to the SharedPref Manager, allowing developers to view and debug encrypted preference files alongside regular ones. The implementation introduces a more flexible architecture by replacing string-based preference names with a provider pattern.

  • Adds encrypted SharedPreferences support with a new button in the sample UI
  • Refactors SharedPref Manager to use a provider pattern instead of string names
  • Updates minimum SDK version to 23 to support encrypted preferences dependency

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sample/src/main/res/values/strings.xml Adds string resource for encrypted SharedPref button
sample/src/main/res/layout/main_fragment.xml Adds new button for encrypted SharedPref manager and adjusts layout constraints
sample/src/main/java/com/trendyol/android/devtools/ui/main/MainFragment.kt Implements encrypted SharedPreferences creation and button click handling
sample/src/main/java/com/trendyol/android/devtools/App.kt Minor import reordering and whitespace cleanup
sample/build.gradle.kts Updates minSdk to 23 and adds encrypted preferences dependency
libraries/sharedpref-manager/src/main/java/com/trendyol/android/devtools/sharedprefmanager/di/SharedPrefUseCaseContainer.kt Refactors to use SharedPreferencesProvider instead of string name
libraries/sharedpref-manager/src/main/java/com/trendyol/android/devtools/sharedprefmanager/di/ContextContainer.kt Introduces SharedPreferencesProvider sealed class and updates container logic
libraries/sharedpref-manager/src/main/java/com/trendyol/android/devtools/sharedprefmanager/SharedPrefManager.kt Adds overloaded show method accepting SharedPreferences instance
libraries/sharedpref-manager/build.gradle.kts Bumps library version to 0.3.0
gradle/libs.versions.toml Adds encrypted preferences library dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MertNYuksel MertNYuksel merged commit 3c72f08 into develop Aug 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants