Adicionado a busca por palavras chave na api de eventos #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-grocha
approved these changes
Feb 8, 2025
Contributor
marcos-grocha
left a comment
marcos-grocha
left a comment
There was a problem hiding this comment.
Vou deixar aprovado com duas observações que, caso dê tempo, seria interessante alterar!
marcos-grocha
approved these changes
Feb 8, 2025
marcos-grocha
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agora a API de eventos ao receber um parametro query também inclui na sua resposta eventos cujo a query seja o valor contigo na palavra chave.
Detalhes:
Na função self.search foi apenas adicionado agora uma left join para pegar também as Keywords.
E adicionados 2 Testes um com sucesso e falha.
Reutilizado toda a estrutura que já tinha sido criaada para essa função, apenas adicionado uma query SQL a mais na def.