Sync current state of analog controls on pedalboard load#114
Open
sastraxi wants to merge 1 commit intoTreeFallSound:pistomp-v3from
Open
Sync current state of analog controls on pedalboard load#114sastraxi wants to merge 1 commit intoTreeFallSound:pistomp-v3from
sastraxi wants to merge 1 commit intoTreeFallSound:pistomp-v3from
Conversation
sastraxi
force-pushed
the
feat/analog-control-sync
branch
from
d18690e to
11beee2
Compare
rreichenbach
approved these changes
Jan 25, 2026
Collaborator
rreichenbach
left a comment
rreichenbach
left a comment
There was a problem hiding this comment.
This is cool. I can't merge it though since this fork/branch needs a rebase.
|
This is very cool — thanks for the implementation. Since my unit has a lot of analog controls, I was wondering if this behavior could be made optional. For example, a per-control toggle in the analog control definition (something like autosync=1). For some controls it’s great to sync immediately on preset/pedalboard change, but for others I’d prefer to keep the value stored in the snapshot until the control is moved. From a usability standpoint, having this as a per-control option would cover both use cases cleanly. Thanks again for the great contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using e.g. expression pedals with MOD pedalboard, this PR adds an initial "sync" where we read the value of the GPIO pin and send a MIDI message so that we don't have to e.g. wiggle the pedal to get it to reflect the current state of the analog input.