Skip to content

Gracefully handle the collaborator missing error #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samirsilwal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gracefully handle the collaborator missing error #88

samirsilwal wants to merge 1 commit into from

Conversation

@samirsilwal
Copy link

@samirsilwal samirsilwal commented Oct 13, 2024 •
edited
Loading

Changes

  • Wrap the collaborator review request API call with try catch
  • Just log the error instead of failing the action status
  • It creates the PR despite before but the action run status is set to error which is a bit annoying. So, error info is shown instead which gives info about the handling

Test

  • Messages shown when error

Before

https://github.com/samirsilwal/sync-branches/actions/runs/11310223756/job/31455026490

After

image

@samirsilwal samirsilwal mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mesaugat mesaugat mesaugat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samirsilwal @mesaugat