Skip to content

U low patch 2 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
uLow wants to merge 7 commits into
base: master
Choose a base branch
from
Open

U low patch 2 #43

uLow wants to merge 7 commits into from

Conversation

@uLow
Copy link
Contributor

@uLow uLow commented May 31, 2016 •
edited
Loading

To improve test speed based on timeout (default 30sec):

  • Added custom request executor setter with ability to set custom curl timeout
  • Added tests for new functional

@uLow
Copy link
Contributor Author

uLow commented May 31, 2016

Phpunit is now executing for ~1 minute instead of 7+.
We can try minimize curl timeout to 3 seconds instead of 5 to make it even faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uLow