Skip to content

Fix multiple videos using external_videos dataset #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victorjoos merged 2 commits into from
Jun 27, 2025
Merged

Fix multiple videos using external_videos dataset #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63c8427
Always open a video file from zero and seek to correct position
victorjoos Jun 27, 2025
393ffb8
Bigger factor between image_ids of diff videos
victorjoos Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tracklab/utils/cv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,10 @@
class VideoReader:
def __init__(self):
self.filename = None
self.cap = None # cv2.VideoCapture(filename)

def set_filename(self, filename):
# TODO: remove this function, and set self.filename directly
self.filename = filename
if self.cap is not None:
self.cap.release()
self.cap = cv2.VideoCapture(self.filename)
assert self.cap.isOpened(), "Error opening video stream or file"

def __getitem__(self, idx):
assert self.filename is not None, "You should first set the filename"
Expand Down
2 changes: 1 addition & 1 deletion tracklab/wrappers/dataset/external_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def __init__(self, dataset_path: str, video_path: str, *args, **kwargs):
image_metadata.extend(
[
{
"id": j+1000*i,
"id": j+100_000*i, # TODO: read the number of frames to get the right factor
"name": f"{video_name}_{j}",
"frame": j,
"nframes": nframes,
Expand Down