Update date format to use 24hr based on locale.#1
Open
apocolipse wants to merge 1 commit intoTr1Fecta-7:masterfrom
Open
Update date format to use 24hr based on locale.#1apocolipse wants to merge 1 commit intoTr1Fecta-7:masterfrom
apocolipse wants to merge 1 commit intoTr1Fecta-7:masterfrom
Conversation
Current implementation uses a blanket `HH` date format (24h) which is incorrect, as many users/locales default to a 12 hour format (`hh`). This fix bases the format on the current locale set, however it would be better to directly check or listen to changes in the system preferences.
Owner
|
Thanks for the pull request, I already actually have fixed the issue, but forgot to push. I’ll do it tonight. The fix can be done easier ;), but thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation uses a blanket
HHdate format (24h) which is incorrect, as many users/locales default to a 12 hour format (hh). This fix bases the format on the current locale set, however it would be better to directly check or listen to changes in the system preferences.