Skip to content

Fix bug causing ClassCastException when casting Integer,Short,... to Long object type #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a2mo merged 1 commit into from
Dec 24, 2025
Merged

Fix bug causing ClassCastException when casting Integer,Short,... to Long object type #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ain/java/com/tosan/client/redis/impl/localCacheManager/caffeine/CaffeineCacheManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.tosan.client.redis.api.listener.CacheListener;
import com.tosan.client.redis.api.listener.CaffeineCacheListener;
import com.tosan.client.redis.enumuration.LocalCacheProvider;
import com.tosan.client.redis.exception.TedissonRuntimeException;
import com.tosan.client.redis.impl.localCacheManager.LocalCacheManagerBase;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.collections4.CollectionUtils;
Expand Down Expand Up @@ -155,7 +156,11 @@ private CaffeineElement incrementAtomicItemProcess(CaffeineElement element) {
newCaffeineElement.setValue(1L);
return newCaffeineElement;
}
element.setValue((long) element.getValue() + 1);
Object value = element.getValue();
if (!(value instanceof Number)) {
throw new TedissonRuntimeException("Value must be numeric");
}
element.setValue(((Number) value).longValue() + 1);
return element;
}

Expand Down
32 changes: 30 additions & 2 deletions ...-starter/src/test/java/com/tosan/client/redis/api/integration/LocalCacheManagerITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import java.util.Set;
import java.util.concurrent.TimeUnit;


class LocalCacheManagerITest extends BaseITest {

public static final String CACHE_WITH_SIZE = "CACHE_WITH_SIZE";
Expand All @@ -34,7 +33,6 @@ void testCreateCache() {
Assertions.assertTrue(localCacheManager.isCacheExist(TEST_WITH_EXPIRY_TTL_TTI));
}


@Test
void testClearCache() {
String cacheName = "testClearCache";
Expand Down Expand Up @@ -305,6 +303,36 @@ void testExpireAtomicItemExpiration() throws InterruptedException {
Assertions.assertEquals(1, localCacheManager.incrementAndGetAtomicItem(cacheName, "atomicKey"));
}

@Test
void testIncrementAtomicIntegerValueItem() {
String cacheName = "testIncrementAtomicIntegerValueItem";
String key = "atomicKey";
localCacheManager.createCache(cacheName);
Integer item = Integer.valueOf(1);
localCacheManager.addItemToCache(cacheName, key, item);
Assertions.assertEquals(2, localCacheManager.incrementAndGetAtomicItem(cacheName, key));
}

@Test
void testIncrementAtomicLongValueItem() {
String cacheName = "testIncrementAtomicLongValueItem";
String key = "atomicKey";
localCacheManager.createCache(cacheName);
Long item = Long.valueOf(1);
localCacheManager.addItemToCache(cacheName, key, item);
Assertions.assertEquals(2, localCacheManager.incrementAndGetAtomicItem(cacheName, key));
}

@Test
void testIncrementAtomicShortValueItem() {
String cacheName = "testIncrementAtomicShortValueItem";
String key = "atomicKey";
localCacheManager.createCache(cacheName);
Short item = Short.valueOf((short) 1);
localCacheManager.addItemToCache(cacheName, key, item);
Assertions.assertEquals(2, localCacheManager.incrementAndGetAtomicItem(cacheName, key));
}

@Test
void testUpdateAtomicItemExpiration() throws InterruptedException {
String cacheName = "testUpdateAtomicItemExpiration";
Expand Down