Skip to content

Conversation

@isaiah-harville
Copy link
Contributor

Closes #334

@isaiah-harville
Copy link
Contributor Author

isaiah-harville commented Mar 20, 2025

Requirements are changed/added/removed in requirements.in and the locked requirements.txt file is regenerated with:
pip-compile requirements.in in Python v3.10. As a rule of thumb, generate these files with the lowest supported python version. The pip-compile command is found in the pip-tools python package.

Lots of benefits to this, especially for the docker image building process. It is usually preferred to copy over the requirements.txt file into the image and pip install requirements that way.

@ereoh
Copy link
Collaborator

ereoh commented Mar 21, 2025

add me or @MattCarrickPL as a reviewer, but otherwise looks good, thanks!

@MattCarrickPL MattCarrickPL changed the base branch from main to 1.1.0-dev March 21, 2025 14:16
@isaiah-harville isaiah-harville marked this pull request as draft March 21, 2025 14:19
@isaiah-harville isaiah-harville marked this pull request as ready for review March 21, 2025 14:19
@isaiah-harville
Copy link
Contributor Author

add me or @MattCarrickPL as a reviewer, but otherwise looks good, thanks!

Unfortunately, it looks like I don't have permission to assign any reviewers.

@MattCarrickPL
Copy link
Collaborator

I've got it set to merge into 1.1.0-dev. I need to test it, then I can approve a merge. Thanks @IsaiahHarvi !

@MattCarrickPL MattCarrickPL merged commit ba2a976 into TorchDSP:1.1.0-dev Mar 21, 2025
@MattCarrickPL MattCarrickPL mentioned this pull request Mar 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Version lock files with requirements.txt

3 participants