Skip to content

Conversation

@jmoggr
Copy link
Collaborator

@jmoggr jmoggr commented Dec 1, 2025

No description provided.

@jmoggr jmoggr force-pushed the samod branch 4 times, most recently from 06d32e1 to d3f73eb Compare December 1, 2025 16:58
@epatters epatters added enhancement New feature or request backend Backend, including web server and database labels Dec 1, 2025
@epatters epatters changed the title Remove automerge-doc-server and serve automerge-repo from backend Remove automerge-doc-server and sync Automerge docs from backend using samod Dec 1, 2025
@github-actions github-actions bot temporarily deployed to netlify-preview December 15, 2025 18:03 Destroyed
@github-actions github-actions bot temporarily deployed to netlify-preview January 5, 2026 17:56 Destroyed
@github-actions github-actions bot temporarily deployed to netlify-preview January 5, 2026 17:58 Destroyed
@jmoggr jmoggr marked this pull request as ready for review January 5, 2026 18:01
@github-actions github-actions bot temporarily deployed to netlify-preview January 5, 2026 18:32 Destroyed
@github-actions github-actions bot temporarily deployed to netlify-preview January 5, 2026 18:49 Destroyed
@jmoggr jmoggr requested a review from epatters January 6, 2026 19:29
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason, this is great! I'm excited to have a simpler architecture and it's beautiful to see all that deleted code.

use uuid::Uuid;

/// Insert a JSON value into a map property
fn insert_value_into_map<'a>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have mentioned these helper functions to me before, Jason, but I'm surprised that we have to write them. Is this functionality that you would expect to be upstreamed?

Copy link
Collaborator Author

@jmoggr jmoggr Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only a bit surprised. It seems like not many people are needing to manipulate Automerge docs both from Javascript and Rust, and practically doing that has only recently been made possible with Samod.

We could be the first people to run into this, I'll open an issue on Samod. It seems reasonable to have this functionality upstreamed.

@github-actions github-actions bot temporarily deployed to netlify-preview January 7, 2026 14:33 Destroyed
@jmoggr jmoggr mentioned this pull request Jan 7, 2026
@github-actions github-actions bot temporarily deployed to netlify-preview January 7, 2026 17:14 Destroyed
@jmoggr jmoggr force-pushed the samod branch 2 times, most recently from b511c1d to f4ce62a Compare January 14, 2026 18:14
@github-actions github-actions bot temporarily deployed to netlify-preview January 14, 2026 18:17 Destroyed
@epatters epatters merged commit 27c41e5 into main Jan 15, 2026
51 of 55 checks passed
@epatters epatters deleted the samod branch January 15, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend, including web server and database enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants