-
Notifications
You must be signed in to change notification settings - Fork 40
Remove automerge-doc-server and sync Automerge docs from backend using samod
#875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
06d32e1 to
d3f73eb
Compare
automerge-doc-server and serve automerge-repo from backendautomerge-doc-server and sync Automerge docs from backend using samod
epatters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jason, this is great! I'm excited to have a simpler architecture and it's beautiful to see all that deleted code.
| use uuid::Uuid; | ||
|
|
||
| /// Insert a JSON value into a map property | ||
| fn insert_value_into_map<'a>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have mentioned these helper functions to me before, Jason, but I'm surprised that we have to write them. Is this functionality that you would expect to be upstreamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was only a bit surprised. It seems like not many people are needing to manipulate Automerge docs both from Javascript and Rust, and practically doing that has only recently been made possible with Samod.
We could be the first people to run into this, I'll open an issue on Samod. It seems reasonable to have this functionality upstreamed.
packages/migrator/src/migrations/m20250805230408_fix_automerge_storage.rs
Show resolved
Hide resolved
b511c1d to
f4ce62a
Compare
No description provided.