Skip to content

Conversation

@null8626
Copy link
Member

@null8626 null8626 commented Mar 7, 2025

The following pull request deprecates many legacy features that are no longer supported/ignored/removed in Top.gg API v0 while also adding many new features, such as page in getVotes and support for reviews.

velddev
velddev previously approved these changes Mar 7, 2025
velddev
velddev previously approved these changes Mar 7, 2025
@null8626
Copy link
Member Author

null8626 commented Mar 9, 2025

Updated mock tests to adapt with the new changes.

@null8626 null8626 requested a review from velddev March 9, 2025 03:35
Copy link
Member

@jpbberry jpbberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what's the deal with all of these formatting changes? I don't see any changes to the https://github.com/top-gg/eslint-config

We should be following that, surprised it's not failing the build.
Please revert to the format before, same spacing settings and double quotes, check the linter locally

@jpbberry
Copy link
Member

jpbberry commented Mar 9, 2025

(Make sure to get the testing files too with formatting revert)

@null8626
Copy link
Member Author

null8626 commented Mar 10, 2025

Also what's the deal with all of these formatting changes? I don't see any changes to the https://github.com/top-gg/eslint-config

We should be following that, surprised it's not failing the build. Please revert to the format before, same spacing settings and double quotes, check the linter locally

The linter not failing the build is probably caused by this, which happens every time I run the linter:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.4.5

Please only submit bug reports when using the officially supported version.

=============

@null8626
Copy link
Member Author

Rerunning this under TypeScript version 5.2.2 gets rid of the warning but still succeeds.

@jpbberry
Copy link
Member

Feel free to bump the typescript version. I'm still seeing many blame changes to the mocking and testing files, and all over the place. Trailing commas spacing etc. Can you just slim down all the changes to purely code and remove all the formatting differences.

@null8626
Copy link
Member Author

Done. Can you check the diff again?

@null8626 null8626 requested a review from jpbberry March 12, 2025 02:35
@jpbberry jpbberry merged commit 4d7cc93 into Top-gg-Community:master Mar 18, 2025
3 checks passed
@null8626 null8626 mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants