-
Notifications
You must be signed in to change notification settings - Fork 45
feat: adapt to Top.gg API v0 #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated mock tests to adapt with the new changes. |
jpbberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what's the deal with all of these formatting changes? I don't see any changes to the https://github.com/top-gg/eslint-config
We should be following that, surprised it's not failing the build.
Please revert to the format before, same spacing settings and double quotes, check the linter locally
|
(Make sure to get the testing files too with formatting revert) |
The linter not failing the build is probably caused by this, which happens every time I run the linter: |
|
Rerunning this under TypeScript version 5.2.2 gets rid of the warning but still succeeds. |
|
Feel free to bump the typescript version. I'm still seeing many blame changes to the mocking and testing files, and all over the place. Trailing commas spacing etc. Can you just slim down all the changes to purely code and remove all the formatting differences. |
|
Done. Can you check the diff again? |
The following pull request deprecates many legacy features that are no longer supported/ignored/removed in Top.gg API v0 while also adding many new features, such as
pageingetVotesand support for reviews.