-
Notifications
You must be signed in to change notification settings - Fork 154
add progress event #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djulien
wants to merge
6
commits into
TooTallNate:master
Choose a base branch
from
djulien:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add progress event #107
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bd1de0e
emit progress event to give some playback data
djulien 8c20c19
add progress event
djulien b2b8935
pull in recent changes from TooTallNate's version
djulien ef0e8de
reduce latency: add sync progress data, remove async event emit
djulien 8d24922
try to add volume (!worky yet)
djulien 61af96d
add volume control (broken)
djulien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { Writable, WritableOptions } from 'stream'; | ||
|
|
||
| export interface Options extends WritableOptions { | ||
| readonly channels?: number; | ||
| readonly bitDepth?: number; | ||
| readonly sampleRate?: number; | ||
| readonly lowWaterMark?: number; | ||
| readonly highWaterMark?: number; | ||
| } | ||
|
|
||
| export interface Format { | ||
| readonly float?: boolean; | ||
| readonly signed?: boolean; | ||
| readonly bitDepth?: number; | ||
| readonly channels?: number; | ||
| readonly sampleRate?: number; | ||
| readonly samplesPerFrame?: number; | ||
| } | ||
|
|
||
| /** | ||
| * The `Speaker` class accepts raw PCM data written to it, and then sends that data | ||
| * to the default output device of the OS. | ||
| * | ||
| * @param opts options. | ||
| */ | ||
| export default class Speaker extends Writable { | ||
| constructor(opts?: Options); | ||
|
|
||
| /** | ||
| * Closes the audio backend. Normally this function will be called automatically | ||
| * after the audio backend has finished playing the audio buffer through the | ||
| * speakers. | ||
| * | ||
| * @param flush Defaults to `true`. | ||
| */ | ||
| public close(flush: boolean): string; | ||
|
|
||
| /** | ||
| * Returns the `MPG123_ENC_*` constant that corresponds to the given "format" | ||
| * object, or `null` if the format is invalid. | ||
| * | ||
| * @param format format object with `channels`, `sampleRate`, `bitDepth`, etc. | ||
| * @return MPG123_ENC_* constant, or `null` | ||
| */ | ||
| public getFormat(format: Format): number | null; | ||
|
|
||
| /** | ||
| * Returns whether or not "format" is playable via the "output module" | ||
| * that was selected during compilation. | ||
| * | ||
| * @param format MPG123_ENC_* format constant | ||
| * @return whether or not is playable | ||
| */ | ||
| public isSupported(format: number): boolean; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try and name these something more human friendly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it would be a kind of acknowledgement or ack .