Add integration tests for process_html_file with flite#9
Merged
Conversation
Co-Authored-By: tom mottes <tom.mottes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests for process_html_file with flite
Summary
Adds 9 end-to-end integration tests for
process_html_filethat actually invoke the flite binary. Tests are intentionally loose to allow changes in output format/reductions without breaking:All tests are gated behind a
@requires_fliteskip marker — they are skipped automatically if the flite binary isn't built.Review & Testing Checklist for Human
.github/workflows/tests.ymlto addsubmodules: trueto the checkout step and acd flite && ./configure && make -j$(nproc)build step.test_multiple_paragraphsasserts>= 6<p>tags for 3 input paragraphs (assumes each paragraph produces an IPA + original pair). Verify this matches the intendedprocess_html_filecontract and is loose enough for future format changes.git submodule update --init && cd flite && ./configure && make -j$(nproc)thenpython -m pytest test_main.py::TestProcessHtmlFileIntegration -vlocally to confirm all 9 tests pass on your machine.Notes