Add missing objects for TR2/TR3 #928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TokyoSU
commented
Oct 29, 2024
TokyoSU
commented
- Added missing or unused TR2 and TR3 objects to avoid forgetting it.
- Added "(sprite)" postfix to TR2 sprite object.
- Added missing old flip effect for TR4.
- Also add missing old flip effect for TR4.
Stranger1992
requested changes
Dec 30, 2024
Member
Stranger1992
left a comment
Stranger1992
left a comment
There was a problem hiding this comment.
Please take a look at my review notes and also provide references to where the unused items information is held
| <limit name="TexPages" value="32" /> | ||
| <limit name="TexInfos" value="2000" /> | ||
| <limit name="TexPages" value="1024" /> | ||
| <limit name="TexInfos" value="32768" /> |
Member
There was a problem hiding this comment.
Is this limit for TR2Main (or whatever the patched engine is called?)
| <moveable id="183" name="Puzzle 2 hole" ten="PUZZLE_HOLE2" /> | ||
| <moveable id="184" name="Puzzle 3 hole" ten="PUZZLE_HOLE3" /> | ||
| <moveable id="185" name="Puzzle 4 hole" ten="PUZZLE_HOLE4" /> | ||
| <moveable id="186" name="Puzzle 1 done" ten="PUZZLE_DONE3" /> |
Member
There was a problem hiding this comment.
This is wrong. TEN remap is PuzzleDone1
| <moveable id="226" name="Gong (Ice Palace)" essential="false" ten="ANIMATING1" /> | ||
| <moveable id="227" name="Detonator box" essential="false" ten="ANIMATING1" /> | ||
| <moveable id="228" name="Helicopter (Diving Area)" essential="false" ten="ANIMATING1" /> | ||
| <moveable id="235" name="Flare burning?" hidden="true" /> |
| <moveable id="249" name="Harpoon (flying)" hidden="true" ten="HARPOON" /> | ||
| <moveable id="251" name="Spark emitter" essential="false" ten="KNIFETHROWER_KNIFE"/> | ||
| <!--<moveable id="250" name="Lava split (Sprite)" hidden="true" />--> | ||
| <moveable id="251" name="Lava emitter" essential="false" ten="KNIFETHROWER_KNIFE"/> |
Member
There was a problem hiding this comment.
Remap is wrong. Should be LAVA_EMITTER (please check exact name in TEN)
| <moveable id="30" name="Assault-course target" essential="false" ten="SHOOT_SWITCH1" /> | ||
| <moveable id="31" name="Crawler mutant in closet" essential="false" ten="ANIMATING108"/> | ||
| <moveable id="32" name="Crocodile (in water)" essential="false" /> | ||
| <moveable id="33" name="Butterfly [unused]" essential="false" /> |
Member
There was a problem hiding this comment.
Please change square brackets to parenthesis
| <moveable id="40" name="RX-Tech guy with gun" essential="false" ten="SAS_CAIRO" /> | ||
| <moveable id="41" name="Dog (Antarctica)" essential="false" ten="HUSKIE"/> | ||
| <moveable id="42" name="Crawler mutant" essential="false" ten="SEAL_MUTANT" /> | ||
| <moveable id="43" name="Willard [unused]" essential="false" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.