Almost completely refactored `TombIDE.ProjectMaster` #1079

Nickelony · 2025-11-16T20:23:32Z

No description provided.

Copilot

Pull Request Overview

This PR implements a comprehensive refactoring of the TombIDE.ProjectMaster project, introducing modern C# patterns and a service-oriented architecture.

Key Changes:

Enabled nullable reference types and upgraded to C# 12
Introduced service layer abstractions with dependency injection support
Extracted engine update, plugin management, and archive creation logic into dedicated services
Modernized code with file-scoped namespaces, expression-bodied members, and pattern matching

Reviewed Changes

Copilot reviewed 73 out of 75 changed files in this pull request and generated 26 comments.

Show a summary per file

File	Description
TombIDE.ProjectMaster.csproj	Enabled nullable reference types and C# 12
Services/EngineUpdate/*.cs	Extracted engine update logic into game-specific services
Services/Plugins/*.cs	Refactored plugin management into discovery, installation, deployment services
Services/ArchiveCreation/*.cs	Created service layer for game archive generation with async support
Services/Settings/*.cs	Introduced services for managing startup images, splash screens, logos, etc.
PluginManager.cs	Simplified by delegating to plugin services
LevelManager.cs	Refactored to use version and update services
FormGameArchive.cs	Converted to async/await pattern with progress reporting

Files not reviewed (2)

TombIDE/TombIDE.ProjectMaster/Forms/FormGameArchive.Designer.cs: Language not supported
TombIDE/TombIDE.ProjectMaster/Forms/FormPleaseWait.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

TombIDE/TombIDE.ProjectMaster/Sections/SectionLevelProperties.cs:406

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

				foreach (DarkTreeNode node in treeView_AllPrjFiles.Nodes)
				{
					if (node.Text.Equals(_ide.SelectedLevel.TargetPrj2FileName, StringComparison.OrdinalIgnoreCase))
					{
						treeView_AllPrjFiles.SelectNode(node);
						nodeFound = true;

						break;
					}
				}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TombIDE/TombIDE.ProjectMaster/Services/Settings/Launcher/LauncherManagementService.cs

TombIDE/TombIDE.ProjectMaster/Services/EngineUpdate/TombEngineUpdateService.cs

TombIDE/TombIDE.ProjectMaster/Services/ArchiveCreation/GameArchiveServiceBase.cs

...IDE/TombIDE.ProjectMaster/Services/Plugins/Initialization/TRNGPluginInitializationService.cs

TombIDE/TombIDE.ProjectMaster/Services/Settings/LogCleaning/LogCleaningService.cs

TombIDE/TombIDE.ProjectMaster/Services/Settings/ProjectInfo/ProjectInfoService.cs

TombIDE/TombIDE.ProjectMaster/Services/LevelCompile/LevelCompileService.cs

Copilot

Pull Request Overview

Copilot reviewed 73 out of 75 changed files in this pull request and generated 8 comments.

Files not reviewed (2)

TombIDE/TombIDE.ProjectMaster/Forms/FormGameArchive.Designer.cs: Language not supported
TombIDE/TombIDE.ProjectMaster/Forms/FormPleaseWait.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

TombIDE/TombIDE.ProjectMaster/Sections/SectionLevelProperties.cs:406

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

				foreach (DarkTreeNode node in treeView_AllPrjFiles.Nodes)
				{
					if (node.Text.Equals(_ide.SelectedLevel.TargetPrj2FileName, StringComparison.OrdinalIgnoreCase))
					{
						treeView_AllPrjFiles.SelectNode(node);
						nodeFound = true;

						break;
					}
				}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TombIDE/TombIDE.ProjectMaster/Sections/SectionLevelProperties.cs

Copilot · 2025-11-17T18:35:20Z

TombIDE/TombIDE.ProjectMaster/Services/EngineUpdate/TombEngineUpdateService.cs

+		var settingsUpdate16 = latestVersion.Major == 1 && latestVersion.Minor >= 6
+			&& currentVersion.Major == 1 && currentVersion.Minor <= 6
+			&& currentVersion <= latestVersion;


The condition logic appears incorrect. When latestVersion is 1.6+ and currentVersion is 1.6 or below, the condition should trigger. However, the current logic checks currentVersion.Minor <= 6 which would be true for 1.6, but then requires currentVersion <= latestVersion which is also true. The issue is that when current is 1.6 and latest is 1.6, this will still trigger the settings update unnecessarily. The condition should be currentVersion.Minor < 6 (strictly less than) instead of <=.

Copilot · 2025-11-17T18:35:20Z

TombIDE/TombIDE.ProjectMaster/Services/LevelCompile/LevelCompileService.cs

+		foreach (ILevelProject level in levels)
+		{
+			string prj2Path = GetPrj2Path(level);
+			batchList.Files.Add(prj2Path);
+		}


This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.

Copilot · 2025-11-17T18:35:20Z

TombIDE/TombIDE.ProjectMaster/Forms/FormGameArchive.cs

+				catch
+				{
+					// Ignore cleanup errors


Generic catch clause.

Suggested change

catch

{

// Ignore cleanup errors

catch (Exception ex)

{

// Ignore cleanup errors, but log for debugging purposes

System.Diagnostics.Debug.WriteLine($"Failed to delete partial archive file: {ex}");

Copilot · 2025-11-17T18:35:21Z

TombIDE/TombIDE.ProjectMaster/Forms/FormGameArchive.cs

+		catch (Exception ex)
 		{
-			string tempDirectory = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
-
-			if (!Directory.Exists(tempDirectory))
-				Directory.CreateDirectory(tempDirectory);
-
-			string engineDirectory = _ide.Project.GetEngineRootDirectoryPath();
-			string targetTempEngineDirectory = Path.Combine(tempDirectory, "Engine");
+			waitForm.Close();

-			foreach (string folder in importantFolders)
-			{
-				if (!Directory.Exists(folder))
-					continue;
-
-				string pathPart = folder.Remove(0, engineDirectory.Length);
-				string targetPath = Path.Combine(targetTempEngineDirectory, pathPart.Trim('\\'));
-
-				SharedMethods.CopyFilesRecursively(folder, targetPath);
-			}
-
-			if (createSavesFolder)
-				Directory.CreateDirectory(Path.Combine(targetTempEngineDirectory, "saves"));
-
-			foreach (string file in importantFiles)
-			{
-				if (!File.Exists(file))
-					continue;
-
-				string pathPart = file.Remove(0, engineDirectory.Length);
-				string targetPath = Path.Combine(targetTempEngineDirectory, pathPart.Trim('\\'));
-
-				string targetDirectory = Path.GetDirectoryName(targetPath);
-
-				if (!Directory.Exists(targetDirectory))
-					Directory.CreateDirectory(targetDirectory);
-
-				File.Copy(file, targetPath);
-			}
+			DarkMessageBox.Show(this, $"Archive creation failed:\n{ex.Message}", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);

-			// Copy launch.exe
-			string launchFilePath = _ide.Project.GetLauncherFilePath();
-
-			if (File.Exists(launchFilePath))
-				File.Copy(launchFilePath, Path.Combine(tempDirectory, Path.GetFileName(launchFilePath)), true);
-
-			if (!string.IsNullOrWhiteSpace(readmeText))
-				File.WriteAllText(Path.Combine(tempDirectory, "README.txt"), readmeText);
-
-			if (File.Exists(filePath))
-				File.Delete(filePath);
-
-			ZipFile.CreateFromDirectory(tempDirectory, filePath);
-
-			if (Directory.Exists(tempDirectory))
-				Directory.Delete(tempDirectory, true);
+			DialogResult = DialogResult.None;
 		}


Generic catch clause.

TombIDE/TombIDE.ProjectMaster/Forms/FormRenameLauncher.cs

Copilot · 2025-11-17T18:35:21Z

TombIDE/TombIDE.ProjectMaster/PluginManager.cs

+			UpdatePlugins();
+		}
+		catch (Exception ex)
 		{


Generic catch clause.

Suggested change

{

{

// Rethrow critical exceptions

if (ex is OutOfMemoryException || ex is StackOverflowException || ex is System.Threading.ThreadAbortException)

throw;

Almost completely refactored TombIDE.ProjectMaster

6547f98

Nickelony requested a review from Copilot November 16, 2025 20:23

Copilot started reviewing on behalf of Nickelony November 16, 2025 20:24 View session

Copilot finished reviewing on behalf of Nickelony November 16, 2025 20:24

Copilot AI reviewed Nov 16, 2025

View reviewed changes

Fixes and cleanups

1845650

Nickelony requested a review from Copilot November 17, 2025 18:27

Copilot started reviewing on behalf of Nickelony November 17, 2025 18:28 View session

Copilot finished reviewing on behalf of Nickelony November 17, 2025 18:29

Copilot AI reviewed Nov 17, 2025

View reviewed changes

Nickelony added 7 commits November 17, 2025 20:17

Plugin services cleanup

56abe8e

Use GameVersion instead of project instance

c4a3c8b

Mid-review adjustments

ea716a2

IsNullOrWhiteSpace

f961703

Remove redundant archive service implementation

b7c6d02

Fix wording in archive creation

21b8965

Remove unnecessary exception

f9a901c

-		{
+		{
+			// Rethrow critical exceptions
+			if (ex is OutOfMemoryException || ex is StackOverflowException || ex is System.Threading.ThreadAbortException)
+				throw;

Almost completely refactored TombIDE.ProjectMaster #1079

Are you sure you want to change the base?

Almost completely refactored TombIDE.ProjectMaster #1079

Uh oh!

Conversation

Nickelony commented Nov 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Almost completely refactored `TombIDE.ProjectMaster` #1079

Almost completely refactored `TombIDE.ProjectMaster` #1079