Skip to content

Conversation

@Nickelony
Copy link
Collaborator

No description provided.

@Nickelony Nickelony requested a review from Copilot September 20, 2025 11:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements conditional relighting functionality to optimize room geometry operations by only performing lighting calculations when necessary.

  • Adds a PendingRelight property to track rooms that need lighting updates
  • Introduces a Rebuild method that conditionally performs relighting based on current editor mode
  • Replaces direct BuildGeometry calls with Rebuild calls throughout the codebase to respect the conditional lighting behavior

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
TombLib/TombLib/LevelData/RoomGeometry.cs Removes highQualityLighting parameter from Build method and removes automatic relighting call
TombLib/TombLib/LevelData/Room.cs Adds PendingRelight property and Rebuild method with conditional relighting logic
TombLib/TombLib/LevelData/Level.cs Updates texture removal to use Rebuild method
TombLib/TombLib/LevelData/IO/PrjLoader.cs Updates project loading to use Rebuild method
TombLib/TombLib/LevelData/IO/Prj2Loader.cs Updates project loading to use Rebuild method
TombEditor/Undo.cs Updates undo operations to use appropriate lighting methods
TombEditor/Forms/FormTextureRemap.cs Updates texture remapping to use Rebuild method
TombEditor/EditorActions.cs Updates all geometry operations to use Rebuild with conditional relighting
TombEditor/Editor.cs Adds ShouldRelight property and automatic relighting when switching to lighting mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Nickelony Nickelony marked this pull request as draft September 20, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants