Overlays

[Nickelony]

No description provided.

[Copilot]

Pull Request Overview

This pull request implements Decals V2 functionality, which introduces a layered texture system for sector faces. The main purpose is to enable decal textures to be rendered on top of base textures for all sector faces (floors, ceilings, and walls).

Key changes:

• Introduces a new FaceLayer enum with Base and Decal values to represent texture layers
• Creates FaceLayerInfo struct that combines a SectorFace with a FaceLayer to uniquely identify face-layer combinations
• Updates all texture-related operations to work with layered textures instead of single textures per face

Reviewed Changes

Copilot reviewed 28 out of 30 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
TombLib/TombLib/Utils/RectTransformation.cs	Updates transformation logic to handle face layer information
TombLib/TombLib/LevelData/SectorStructs/SectorFaceIdentity.cs	Changes face property from SectorFace to FaceLayerInfo
TombLib/TombLib/LevelData/SectorStructs/FaceLayerInfo.cs	New struct combining SectorFace and FaceLayer
TombLib/TombLib/LevelData/SectorEnums/FaceLayer.cs	New enum defining Base, Decal, and Count values
TombLib/TombLib/LevelData/Sector.cs	Updates sector to store textures per face-layer combination
TombLib/TombLib/LevelData/RoomGeometry.cs	Adds support for rendering both base and decal layers
TombLib/TombLib/LevelData/Room.cs	Updates room methods to work with layered face system
Multiple IO files	Updates serialization/deserialization for new texture layer format
Multiple compiler files	Updates level compilers to handle layered textures
TombEditor files	Updates editor UI and functionality for decal layer support

Files not reviewed (1)

• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 29 out of 31 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

• TombEditor/Controls/ToolBox.Designer.cs: Language not supported

Comments suppressed due to low confidence (2)

TombLib/TombLib/LevelData/SectorStructs/SectorFaceIdentity.cs:1

• The Equals method has incorrect logic - it should call Equals(identity) instead of identity.Equals(other). This creates infinite recursion since identity.Equals(other) will call the same method again.

using System;

TombLib/TombLib/LevelData/SectorStructs/SectorFaceIdentity.cs:1

• [nitpick] The readonly modifiers are inconsistent and unnecessary on interface implementations and public methods. Remove 'readonly' from lines 21 and 22 for consistency with standard C# practices.

using System;

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 32 out of 35 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

• TombEditor/Controls/ToolBox.Designer.cs: Language not supported
• TombEditor/Properties/Resources.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

TombLib/TombLib/LevelData/SectorStructs/SectorFaceIdentity.cs:1

• Infinite recursion bug: The method calls identity.Equals(other) instead of identity.Equals(this) or Equals(identity), which will cause a stack overflow.

using System;

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}